third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp - Issue 2170973002: HRTF panner should handle the case of no loaded HRTF database

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

Issue 2170973002: HRTF panner should handle the case of no loaded HRTF database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/audio/EqualPowerPanner.h ('k') | third_party/WebKit/Source/platform/audio/HRTFPanner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

diff --git a/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp b/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

index 2a17a0ff6caac1c5b30d2084286eeb5cfe122dd3..62f0b7affeefdc83af73ae45f42e4469dfca54a5 100644

--- a/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

+++ b/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

@@ -36,7 +36,7 @@ EqualPowerPanner::EqualPowerPanner(float sampleRate)

{

}

-void EqualPowerPanner::pan(double azimuth, double /*elevation*/, const AudioBus* inputBus, AudioBus* outputBus, size_t framesToProcess)

+void EqualPowerPanner::pan(double azimuth, double /*elevation*/, const AudioBus* inputBus, AudioBus* outputBus, size_t framesToProcess, AudioBus::ChannelInterpretation)

{

bool isInputSafe = inputBus && (inputBus->numberOfChannels() == 1 || inputBus->numberOfChannels() == 2) && framesToProcess <= inputBus->length();

ASSERT(isInputSafe);

@@ -153,7 +153,7 @@ void EqualPowerPanner::calculateDesiredGain(double& desiredGainL, double& desire

desiredGainR = std::sin(piOverTwoDouble * desiredPanPosition);

}

-void EqualPowerPanner::panWithSampleAccurateValues(double* azimuth, double* /*elevation*/, const AudioBus* inputBus, AudioBus* outputBus, size_t framesToProcess)

+void EqualPowerPanner::panWithSampleAccurateValues(double* azimuth, double* /*elevation*/, const AudioBus* inputBus, AudioBus* outputBus, size_t framesToProcess, AudioBus::ChannelInterpretation)

{

bool isInputSafe = inputBus && (inputBus->numberOfChannels() == 1 || inputBus->numberOfChannels() == 2) && framesToProcess <= inputBus->length();

DCHECK(isInputSafe);