Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2170953002: Fix MemoryDumpManagerTest's thread unsafe usage of the base::TestIOThread API (Closed)

Created:
4 years, 5 months ago by gab
Modified:
4 years, 5 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@a0_a_0_thread_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MemoryDumpManagerTest's thread unsafe usage of the base::TestIOThread API Also move TestIOThread::PostTaskAndWait to those tests as they were the only user. BUG=629139 Committed: https://crrev.com/6e23c37e5f9bf776010908c2d19a0d842d2c70f1 Cr-Commit-Position: refs/heads/master@{#407577}

Patch Set 1 #

Patch Set 2 : Keep re-enabling base::Thread::Stop() checks for follow-up CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -38 lines) Patch
M base/test/test_io_thread.h View 2 chunks +9 lines, -7 lines 0 comments Download
M base/test/test_io_thread.cc View 2 chunks +1 line, -22 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 5 chunks +32 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
gab
Primiano PTAL for MemoryDumpManagerTest Phajdan PTAL for base/test updates (see https://codereview.chromium.org/2145463002/ for reasoning)
4 years, 5 months ago (2016-07-21 19:25:58 UTC) #3
Primiano Tucci (use gerrit)
LGTM
4 years, 5 months ago (2016-07-22 16:55:46 UTC) #4
gab
Thanks, @dana for base/ since Pawel appears to have just left on vacation (this is ...
4 years, 5 months ago (2016-07-22 16:59:48 UTC) #6
gab
On 2016/07/22 16:59:48, gab wrote: > Thanks, @dana for base/ since Pawel appears to have ...
4 years, 5 months ago (2016-07-25 14:54:23 UTC) #7
danakj
LGTM
4 years, 5 months ago (2016-07-25 18:50:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170953002/20001
4 years, 5 months ago (2016-07-25 20:12:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-25 21:21:56 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:24:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e23c37e5f9bf776010908c2d19a0d842d2c70f1
Cr-Commit-Position: refs/heads/master@{#407577}

Powered by Google App Engine
This is Rietveld 408576698