Issue 2182643002: Re-enable Thread::Stop() sequence checks and consequently remove |thread_lock|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2182643002: Re-enable Thread::Stop() sequence checks and consequently remove |thread_lock|.

Created:
4 years, 5 months ago by gab

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@a0_a_1_memorydumpmanagertests

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Re-enable Thread::Stop() sequence checks and consequently remove |thread_lock|. BUG=629139

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -20 lines)			Patch
	M	base/threading/thread.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	base/threading/thread.cc	View		3 chunks	+7 lines, -19 lines	0 comments	Download

Depends on Patchset:

Issue 2170953002 Patch 20001

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

gab

The CQ bit was checked by gab@chromium.org to run a CQ dry run

4 years, 5 months ago (2016-07-25 18:24:13 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182643002/1

4 years, 5 months ago (2016-07-25 18:24:33 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 5 months ago (2016-07-25 19:06:37 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/40889)

4 years, 5 months ago (2016-07-25 19:06:38 UTC) #4

gab

4 years, 1 month ago (2016-11-18 16:37:04 UTC) #5

Description was changed from

==========
Re-enable Thread::Stop() sequence checks and consequentially remove
|thread_lock|.

BUG=629139
==========

to

==========
Re-enable Thread::Stop() sequence checks and consequently remove |thread_lock|.

BUG=629139
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages