|
|
Description[perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac
Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on
mac. They were dissabled because the earlier pageset contained google.com
which was being redirected to google.ca. This caused problems with scrolling
action. This cl: https://codereview.chromium.org/2138133003/ updated the
pageset to use google.co.uk to avoid redirection problem. So I am enabling these
benchmarks on mac.
BUG=v8:5019
LOG=N
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/ef22a0b6e115350c09ded4e2dc69b1e1d8c008ba
Cr-Commit-Position: refs/heads/master@{#407138}
Patch Set 1 #
Messages
Total messages: 24 (14 generated)
Description was changed from ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/, updates the pageset to use google.co.uk to avoid redirection problem. So enabling these benchmarks on mac again. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/, updates the pageset to use google.co.uk to avoid redirection problem. So enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without "master." prefix is deprecated: tryserver.chromium.perf For more details, see http://crbug.com/617627.
Description was changed from ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/, updates the pageset to use google.co.uk to avoid redirection problem. So enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/, updates the pageset to use google.co.uk to avoid redirection problem. So enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
mythria@chromium.org changed reviewers: + petrcermak@chromium.org
Hi Petr, I enable the code size benchmarks for mac as well. I disabled them earlier, when there were problems with scrolling. Now, after updating the pageset it should be ok to enable them for mac as well. PTAL. Thanks, Mythri
petrcermak@chromium.org changed reviewers: + nednguyen@google.com
LGTM with the following description nits: * remove comma between the CL link and "updates". * s/updates/updateD/ * s/So enabling/So I'M enabling/ I'm a tools/perf owner only for system-health related stuff, so PLEASE WAIT for Ned to sign this off. Thanks, Petr
lgtm
Description was changed from ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/, updates the pageset to use google.co.uk to avoid redirection problem. So enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/ updated the pageset to use google.co.uk to avoid redirection problem. So I am enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ==========
Thanks Petr and ned. I updated the description with Petr's comments. Regards, Mythri
The CQ bit was checked by mythria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
The CQ bit was checked by mythria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/ updated the pageset to use google.co.uk to avoid redirection problem. So I am enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/ updated the pageset to use google.co.uk to avoid redirection problem. So I am enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/ updated the pageset to use google.co.uk to avoid redirection problem. So I am enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/ updated the pageset to use google.co.uk to avoid redirection problem. So I am enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/ef22a0b6e115350c09ded4e2dc69b1e1d8c008ba Cr-Commit-Position: refs/heads/master@{#407138} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ef22a0b6e115350c09ded4e2dc69b1e1d8c008ba Cr-Commit-Position: refs/heads/master@{#407138} |