Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 2170853002: [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac (Closed)

Created:
4 years, 5 months ago by mythria
Modified:
4 years, 5 months ago
Reviewers:
nednguyen, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac Enable top_10_mobile_memory and top_10_mobile_memory_ignition benchmarks on mac. They were dissabled because the earlier pageset contained google.com which was being redirected to google.ca. This caused problems with scrolling action. This cl: https://codereview.chromium.org/2138133003/ updated the pageset to use google.co.uk to avoid redirection problem. So I am enabling these benchmarks on mac. BUG=v8:5019 LOG=N CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/ef22a0b6e115350c09ded4e2dc69b1e1d8c008ba Cr-Commit-Position: refs/heads/master@{#407138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/perf/benchmarks/v8.py View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-21 09:23:11 UTC) #4
mythria
Hi Petr, I enable the code size benchmarks for mac as well. I disabled them ...
4 years, 5 months ago (2016-07-21 15:09:56 UTC) #9
petrcermak
LGTM with the following description nits: * remove comma between the CL link and "updates". ...
4 years, 5 months ago (2016-07-21 15:17:39 UTC) #11
nednguyen
lgtm
4 years, 5 months ago (2016-07-21 15:22:55 UTC) #12
mythria
Thanks Petr and ned. I updated the description with Petr's comments. Regards, Mythri
4 years, 5 months ago (2016-07-21 15:51:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170853002/1
4 years, 5 months ago (2016-07-21 15:52:18 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/424)
4 years, 5 months ago (2016-07-21 17:05:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170853002/1
4 years, 5 months ago (2016-07-22 09:40:08 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 12:25:45 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 12:27:35 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef22a0b6e115350c09ded4e2dc69b1e1d8c008ba
Cr-Commit-Position: refs/heads/master@{#407138}

Powered by Google App Engine
This is Rietveld 408576698