tools/perf/benchmarks/v8.py - Issue 2170853002: [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2170853002: [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/v8.py

diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py

index 6d7eb7acc5e02b8095d0ff3cb7a8746390fe3451..ffadae43d73e32a3fcd15272c7c6321992387746 100644

--- a/tools/perf/benchmarks/v8.py

+++ b/tools/perf/benchmarks/v8.py

@@ -240,9 +240,6 @@ class _V8MemoryAndCodeSizeBenchmark(perf_benchmark.PerfBenchmark):

@benchmark.Disabled('reference')

-# TODO(crbug.com/617814): Temporarily disable this benchmark for mac. Scrolling

-# does not work on for google.com web page. Remove this once it is fixed.

-@benchmark.Disabled('mac')

class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark):

"""Measures V8 heap and code size with ignition enabled on mobile web pages.

@@ -259,9 +256,6 @@ class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark):

@benchmark.Disabled('reference')

-# TODO(crbug.com/617914): Temporarily disable this benchmark for mac. Scrolling

-# does not work on for google.com web page. Remove this once it is fixed.

-@benchmark.Disabled('mac')

class V8MobileCodeSize(_V8MemoryAndCodeSizeBenchmark):

"""Measures V8 heap and code size on mobile web pages.

« no previous file with comments | « no previous file | no next file » | no next file with comments »