Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 2170853002: [perf] Enable top_10_mobile_memory and top_10_mobile_memory_ignition for mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import re 5 import re
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from page_sets import google_pages 9 from page_sets import google_pages
10 10
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 # https://codereview.chromium.org/2018503002/ lands in Catapult and rolls 233 # https://codereview.chromium.org/2018503002/ lands in Catapult and rolls
234 # into Chromium. 234 # into Chromium.
235 if (('subsystem' in value.name or 'reported_by_chrome' in value.name) and 235 if (('subsystem' in value.name or 'reported_by_chrome' in value.name) and
236 'v8' not in value.name): 236 'v8' not in value.name):
237 return False # Drop non-V8 values reported by Chrome. 237 return False # Drop non-V8 values reported by Chrome.
238 # Keep dump counts and average+max of process counts, vmstats and v8. 238 # Keep dump counts and average+max of process counts, vmstats and v8.
239 return not cls._IGNORED_V8_STATS_RE.search(value.name) 239 return not cls._IGNORED_V8_STATS_RE.search(value.name)
240 240
241 241
242 @benchmark.Disabled('reference') 242 @benchmark.Disabled('reference')
243 # TODO(crbug.com/617814): Temporarily disable this benchmark for mac. Scrolling
244 # does not work on for google.com web page. Remove this once it is fixed.
245 @benchmark.Disabled('mac')
246 class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark): 243 class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark):
247 """Measures V8 heap and code size with ignition enabled on mobile web pages. 244 """Measures V8 heap and code size with ignition enabled on mobile web pages.
248 245
249 http://www.chromium.org/developers/design-documents/rendering-benchmarks 246 http://www.chromium.org/developers/design-documents/rendering-benchmarks
250 """ 247 """
251 248
252 def SetExtraBrowserOptions(self, options): 249 def SetExtraBrowserOptions(self, options):
253 super(V8MobileCodeSizeIgnition, self).SetExtraBrowserOptions(options) 250 super(V8MobileCodeSizeIgnition, self).SetExtraBrowserOptions(options)
254 v8_helper.EnableIgnition(options) 251 v8_helper.EnableIgnition(options)
255 252
256 @classmethod 253 @classmethod
257 def Name(cls): 254 def Name(cls):
258 return 'top_10_mobile_memory_ignition' 255 return 'top_10_mobile_memory_ignition'
259 256
260 257
261 @benchmark.Disabled('reference') 258 @benchmark.Disabled('reference')
262 # TODO(crbug.com/617914): Temporarily disable this benchmark for mac. Scrolling
263 # does not work on for google.com web page. Remove this once it is fixed.
264 @benchmark.Disabled('mac')
265 class V8MobileCodeSize(_V8MemoryAndCodeSizeBenchmark): 259 class V8MobileCodeSize(_V8MemoryAndCodeSizeBenchmark):
266 """Measures V8 heap and code size on mobile web pages. 260 """Measures V8 heap and code size on mobile web pages.
267 261
268 http://www.chromium.org/developers/design-documents/rendering-benchmarks 262 http://www.chromium.org/developers/design-documents/rendering-benchmarks
269 """ 263 """
270 264
271 @classmethod 265 @classmethod
272 def Name(cls): 266 def Name(cls):
273 return 'top_10_mobile_memory' 267 return 'top_10_mobile_memory'
274 268
(...skipping 28 matching lines...) Expand all
303 return True 297 return True
304 # http://crbug.com/623576 298 # http://crbug.com/623576
305 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or 299 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
306 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'): 300 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
307 return True 301 return True
308 return False 302 return False
309 303
310 @classmethod 304 @classmethod
311 def ShouldTearDownStateAfterEachStoryRun(cls): 305 def ShouldTearDownStateAfterEachStoryRun(cls):
312 return True 306 return True
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698