Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2170793004: Remove unnecessary getColorSpace() API from SkCodec (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
Brian Osman, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unnecessary getColorSpace() API from SkCodec Not needed since now we can get it from the SkImageInfo. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2170793004 Committed: https://skia.googlesource.com/skia/+/530c844d25340eb2f2a4500c99c3f9d04a95b66e

Patch Set 1 #

Patch Set 2 : Pass refs more efficiently #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M bench/ColorCodecBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/codec/SkCodec.h View 2 chunks +0 lines, -8 lines 0 comments Download
M include/codec/SkEncodedInfo.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/codec/SkCodec.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/ColorSpaceTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/viewer/ImageSlide.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/visualize_color_gamut.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
msarett
4 years, 5 months ago (2016-07-21 17:10:41 UTC) #4
Brian Osman
lgtm
4 years, 5 months ago (2016-07-21 18:54:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170793004/40001
4 years, 5 months ago (2016-07-21 18:56:12 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:57:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/530c844d25340eb2f2a4500c99c3f9d04a95b66e

Powered by Google App Engine
This is Rietveld 408576698