dm/DMSrcSink.cpp - Issue 2170793004: Remove unnecessary getColorSpace() API from SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMSrcSink.cpp

Issue 2170793004: Remove unnecessary getColorSpace() API from SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Pass refs more efficiently Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMSrcSink.cpp

diff --git a/dm/DMSrcSink.cpp b/dm/DMSrcSink.cpp

index 932d80f570a2bfa9faa307d5766cd90718ff0a2f..f3f5f78b57c2909b39f7df15484a60c03fd0f500 100644

--- a/dm/DMSrcSink.cpp

+++ b/dm/DMSrcSink.cpp

@@ -902,7 +902,7 @@ Error ColorCodecSrc::draw(SkCanvas* canvas) const {

break;

case kDst_sRGB_Mode:

case kDst_HPZR30w_Mode: {

- sk_sp<SkColorSpace> srcSpace = sk_ref_sp(codec->getColorSpace());

+ sk_sp<SkColorSpace> srcSpace = sk_ref_sp(codec->getInfo().colorSpace());

sk_sp<SkColorSpace> dstSpace = (kDst_sRGB_Mode == fMode) ?

SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named) :

SkColorSpace::NewICC(dstData->data(), dstData->size());

« no previous file with comments | « bench/ColorCodecBench.cpp ('k') | include/codec/SkCodec.h » ('j') | no next file with comments »