[telemetry] Fix testTextEntry and testEnterText on Chrome OS

[telemetry] Fix testTextEntry and testEnterText on Chrome OS

Add waits after final keystrokes to ensure the browser has handled them
(before inspecting the <textarea> elements).

BUG=chromium:630017
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/60ef2530645f9f1b0975ccfe4c6554a9e33392da

[petrcermak, 2016-07-21 09:30:20]

Description was changed from

==========
[telemetry] Fix testTextEntry and testEnterText on Chrome OS

Add waits after final keystrokes (before inspecting the <textarea>
elements) to ensure the browser has handled them.

BUG=chromium:630017
==========

to

==========
[telemetry] Fix testTextEntry and testEnterText on Chrome OS

Add waits after final keystrokes to ensure the browser has handled them
(before inspecting the <textarea> elements) .

BUG=chromium:630017
==========

[petrcermak, 2016-07-21 09:30:46]

Description was changed from

==========
[telemetry] Fix testTextEntry and testEnterText on Chrome OS

Add waits after final keystrokes to ensure the browser has handled them
(before inspecting the <textarea> elements) .

BUG=chromium:630017
==========

to

==========
[telemetry] Fix testTextEntry and testEnterText on Chrome OS

Add waits after final keystrokes to ensure the browser has handled them
(before inspecting the <textarea> elements).

BUG=chromium:630017
==========

[petrcermak, 2016-07-21 09:31:45]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com

[petrcermak, 2016-07-21 09:31:45]

PTAL.

Thanks,
Petr

[nednguyen, 2016-07-21 11:24:46]

lgtm

[petrcermak, 2016-07-21 11:25:23]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-07-21 11:25:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 11:51:14]

Description was changed from

==========
[telemetry] Fix testTextEntry and testEnterText on Chrome OS

Add waits after final keystrokes to ensure the browser has handled them
(before inspecting the <textarea> elements).

BUG=chromium:630017
==========

to

==========
[telemetry] Fix testTextEntry and testEnterText on Chrome OS

Add waits after final keystrokes to ensure the browser has handled them
(before inspecting the <textarea> elements).

BUG=chromium:630017

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-21 11:51:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[achuithb, 2016-07-21 19:16:04]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2016-07-21 19:16:05]

https://codereview.chromium.org/2170793003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/actions/action_runner_unittest.py (right):

https://codereview.chromium.org/2170793003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/actions/action_runner_unittest.py:281:
action_runner.Wait(1)
Same as before. I don't think it's good form to have a fixed timeout.

https://codereview.chromium.org/2170793003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/actions/key_event_unittest.py (right):

https://codereview.chromium.org/2170793003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/actions/key_event_unittest.py:80: time.sleep(1)
Wouldn't it be better to do something like:
cond = self._tab.EvaluateJavaScript('document.querySelector("textarea").value')
== 'Hello,\nWorld!';
try:
  util.WaitFor(cond, 30)
  self.assertTrue()
except exceptions.TimeoutException:
  self.assertFalse()

This is less flaky, and also waits only as long as necessary.

[petrcermak, 2016-07-25 11:42:23]

https://codereview.chromium.org/2170793003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/actions/key_event_unittest.py (right):

https://codereview.chromium.org/2170793003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/actions/key_event_unittest.py:80: time.sleep(1)
On 2016/07/21 19:16:05, achuithb wrote:
> Wouldn't it be better to do something like:
> cond =
self._tab.EvaluateJavaScript('document.querySelector("textarea").value')
> == 'Hello,\nWorld!';
> try:
>   util.WaitFor(cond, 30)
>   self.assertTrue()
> except exceptions.TimeoutException:
>   self.assertFalse()
> 
> This is less flaky, and also waits only as long as necessary.

Good point. See https://codereview.chromium.org/2174273002/.