[telemetry] Fix testTextEntry and testEnterText on Chrome OS

telemetry/telemetry/internal/actions/key_event_unittest.py

Index: telemetry/telemetry/internal/actions/key_event_unittest.py
diff --git a/telemetry/telemetry/internal/actions/key_event_unittest.py b/telemetry/telemetry/internal/actions/key_event_unittest.py
index c93e67e5333d5002db0200d25d103d146e7ebe2a..45d4e1bae29eadd72a2e958c964868d799ce9368 100644
--- a/telemetry/telemetry/internal/actions/key_event_unittest.py
+++ b/telemetry/telemetry/internal/actions/key_event_unittest.py
@@ -4,7 +4,6 @@
 
 import time
 
-from telemetry import decorators
 from telemetry.internal.actions import key_event
 from telemetry.internal.actions import utils
 from telemetry.testing import tab_test_case
@@ -57,7 +56,6 @@ class KeyPressActionTest(tab_test_case.TabTestCase):
 
     self.assertEquals(self._scroll_position, 0)
 
-  @decorators.Disabled('chromeos')  # crbug.com/630017.
   def testTextEntry(self):
     # Add an input box to the page.
     self._tab.ExecuteJavaScript(
@@ -77,6 +75,10 @@ class KeyPressActionTest(tab_test_case.TabTestCase):
     self._PressKey('Backspace')
     self._PressKey('Return')
 
+    # Wait for a second to make sure that all keystrokes have been handled by
+    # the browser (crbug.com/630017).
+    time.sleep(1)

[achuithb, 2016/07/21 19:16:05]

Wouldn't it be better to do something like:
cond = self._tab.EvaluateJavaScript('document.querySelector("textarea").value')
== 'Hello,\nWorld!';
try:
  util.WaitFor(cond, 30)
  self.assertTrue()
except exceptions.TimeoutException:
  self.assertFalse()

This is less flaky, and also waits only as long as necessary.

[petrcermak, 2016/07/25 11:42:23]

Good point. See https://codereview.chromium.org/2174273002/.

+
     # Check that the contents of the textarea is correct.
     self.assertEquals('Hello,\nWorld!',
                       self._tab.EvaluateJavaScript(