Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: telemetry/telemetry/internal/actions/action_runner_unittest.py

Issue 2170793003: [telemetry] Fix testTextEntry and testEnterText on Chrome OS (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/actions/action_runner_unittest.py
diff --git a/telemetry/telemetry/internal/actions/action_runner_unittest.py b/telemetry/telemetry/internal/actions/action_runner_unittest.py
index e5f943d91d497beddc91fc68cc18f6dbcc8ba42d..3b190c8cf8547f2aa4863d625110dc601f572eaf 100644
--- a/telemetry/telemetry/internal/actions/action_runner_unittest.py
+++ b/telemetry/telemetry/internal/actions/action_runner_unittest.py
@@ -255,8 +255,6 @@ class ActionRunnerTest(tab_test_case.TabTestCase):
self.assertTrue(action_runner.EvaluateJavaScript(
'(document.scrollingElement || document.body).scrollLeft') > 75)
-
- @decorators.Disabled('chromeos') # crbug.com/630017.
def testEnterText(self):
self.Navigate('blank.html')
self._tab.ExecuteJavaScript(
@@ -278,6 +276,10 @@ class ActionRunnerTest(tab_test_case.TabTestCase):
action_runner.PressKey('Backspace', repeat_count=3) # This is |ing.
action_runner.EnterText('interest') # This is interest|ing.
+ # Wait for a second to make sure that all keystrokes have been handled by
+ # the browser (crbug.com/630017).
+ action_runner.Wait(1)
achuithb 2016/07/21 19:16:05 Same as before. I don't think it's good form to ha
+
self.assertEqual('This is interesting',
self._tab.EvaluateJavaScript(
'document.querySelector("textarea").value'))

Powered by Google App Engine
This is Rietveld 408576698