Fix the incorrect Better/Worse labelling in the results page.

Fix the incorrect Better/Worse labelling in the results page.

R=nduca@chromium.org

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260639

[Sébastien Marchand, 2014-03-28 20:13:50]

Hey, can you take a look at this please ? I don't know anything about JS, so
this might be wrong but at least it give me the correct labelling :). Thanks !

[Sébastien Marchand, 2014-03-28 20:14:18]

And please flip the CQ bit if this LGTY.

[tonyg, 2014-03-31 15:10:41]

https://codereview.chromium.org/217013004/diff/1/tools/telemetry/support/html...
File tools/telemetry/support/html_output/results-template.html (right):

https://codereview.chromium.org/217013004/diff/1/tools/telemetry/support/html...
tools/telemetry/support/html_output/results-template.html:334: return
window.unitToBiggerIsBetter[this.unit()];
unit() calls computeScalingFactorIfNeeded(), which I think will break this
lookup -- because the table might have "ms", but the scaled unit might be "s".

Is the problem rather that the var unit in the for-loop above masks the class
wide scoped "unit"? Maybe just try changing the name of the var in the for loop
and see if it fixes your problem?

[Sébastien Marchand, 2014-03-31 16:56:04]

Thanks, PTAnL.

https://codereview.chromium.org/217013004/diff/1/tools/telemetry/support/html...
File tools/telemetry/support/html_output/results-template.html (right):

https://codereview.chromium.org/217013004/diff/1/tools/telemetry/support/html...
tools/telemetry/support/html_output/results-template.html:334: return
window.unitToBiggerIsBetter[this.unit()];
On 2014/03/31 15:10:41, tonyg wrote:
> unit() calls computeScalingFactorIfNeeded(), which I think will break this
> lookup -- because the table might have "ms", but the scaled unit might be "s".
> 
> Is the problem rather that the var unit in the for-loop above masks the class
> wide scoped "unit"? Maybe just try changing the name of the var in the for
loop
> and see if it fixes your problem?

Changing the name of the var worked :), thanks.

[tonyg, 2014-03-31 16:56:30]

lgtm

[tonyg, 2014-03-31 16:56:35]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-03-31 16:57:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/217013004/20001

[commit-bot: I haz the power, 2014-03-31 20:43:06]

Change committed as 260639