Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Side by Side Diff: tools/telemetry/support/html_output/results-template.html

Issue 217013004: Fix the incorrect Better/Worse labelling in the results page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only update the name of the variable used in the for loop. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <title>Telemetry Performance Test Results</title> 4 <title>Telemetry Performance Test Results</title>
5 <style type="text/css"> 5 <style type="text/css">
6 6
7 section { 7 section {
8 background: white; 8 background: white;
9 padding: 10px; 9 padding: 10px;
10 position: relative; 10 position: relative;
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 return cachedScalingFactor; 318 return cachedScalingFactor;
319 } 319 }
320 this.unit = function () { 320 this.unit = function () {
321 computeScalingFactorIfNeeded(); 321 computeScalingFactorIfNeeded();
322 return cachedUnit; 322 return cachedUnit;
323 } 323 }
324 this.biggerIsBetter = function () { 324 this.biggerIsBetter = function () {
325 if (window.unitToBiggerIsBetter == undefined) { 325 if (window.unitToBiggerIsBetter == undefined) {
326 window.unitToBiggerIsBetter = {}; 326 window.unitToBiggerIsBetter = {};
327 var units = JSON.parse(document.getElementById('units-json').textCon tent); 327 var units = JSON.parse(document.getElementById('units-json').textCon tent);
328 for (var unit in units) { 328 for (var u in units) {
329 if (units[unit].improvement_direction == 'up') { 329 if (units[u].improvement_direction == 'up') {
330 window.unitToBiggerIsBetter[unit] = true; 330 window.unitToBiggerIsBetter[u] = true;
331 } 331 }
332 } 332 }
333 } 333 }
334 return window.unitToBiggerIsBetter[unit]; 334 return window.unitToBiggerIsBetter[unit];
335 } 335 }
336 } 336 }
337 337
338 function UndeleteManager() { 338 function UndeleteManager() {
339 var key = 'telemetry_undeleteIds' 339 var key = 'telemetry_undeleteIds'
340 var undeleteIds = localStorage[key]; 340 var undeleteIds = localStorage[key];
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
879 } else { 879 } else {
880 $('#undelete').hide(); 880 $('#undelete').hide();
881 } 881 }
882 } 882 }
883 883
884 </script> 884 </script>
885 <script id="results-json" type="application/json">%json_results%</script> 885 <script id="results-json" type="application/json">%json_results%</script>
886 <script id="units-json" type="application/json">%json_units%</script> 886 <script id="units-json" type="application/json">%json_units%</script>
887 </body> 887 </body>
888 </html> 888 </html>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698