Chromium Code Reviews Chromium Code Reviews
Issue 217013004:
Fix the incorrect Better/Worse labelling in the results page. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <title>Telemetry Performance Test Results</title> | 4 <title>Telemetry Performance Test Results</title> |
| 5 <style type="text/css"> | 5 <style type="text/css"> |
| 6 | 6 |
| 7 section { | 7 section { |
| 8 background: white; | 8 background: white; |
| 9 padding: 10px; | 9 padding: 10px; |
| 10 position: relative; | 10 position: relative; |
| (...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 324 this.biggerIsBetter = function () { | 324 this.biggerIsBetter = function () { |
| 325 if (window.unitToBiggerIsBetter == undefined) { | 325 if (window.unitToBiggerIsBetter == undefined) { |
| 326 window.unitToBiggerIsBetter = {}; | 326 window.unitToBiggerIsBetter = {}; |
| 327 var units = JSON.parse(document.getElementById('units-json').textCon tent); | 327 var units = JSON.parse(document.getElementById('units-json').textCon tent); |
| 328 for (var unit in units) { | 328 for (var unit in units) { |
| 329 if (units[unit].improvement_direction == 'up') { | 329 if (units[unit].improvement_direction == 'up') { |
| 330 window.unitToBiggerIsBetter[unit] = true; | 330 window.unitToBiggerIsBetter[unit] = true; |
| 331 } | 331 } |
| 332 } | 332 } |
| 333 } | 333 } |
| 334 return window.unitToBiggerIsBetter[unit]; | 334 return window.unitToBiggerIsBetter[this.unit()]; |
|
tonyg
2014/03/31 15:10:41
unit() calls computeScalingFactorIfNeeded(), which
Sébastien Marchand
2014/03/31 16:56:05
Changing the name of the var worked :), thanks.
| |
| 335 } | 335 } |
| 336 } | 336 } |
| 337 | 337 |
| 338 function UndeleteManager() { | 338 function UndeleteManager() { |
| 339 var key = 'telemetry_undeleteIds' | 339 var key = 'telemetry_undeleteIds' |
| 340 var undeleteIds = localStorage[key]; | 340 var undeleteIds = localStorage[key]; |
| 341 if (undeleteIds) { | 341 if (undeleteIds) { |
| 342 undeleteIds = JSON.parse(undeleteIds); | 342 undeleteIds = JSON.parse(undeleteIds); |
| 343 } else { | 343 } else { |
| 344 undeleteIds = []; | 344 undeleteIds = []; |
| (...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 879 } else { | 879 } else { |
| 880 $('#undelete').hide(); | 880 $('#undelete').hide(); |
| 881 } | 881 } |
| 882 } | 882 } |
| 883 | 883 |
| 884 </script> | 884 </script> |
| 885 <script id="results-json" type="application/json">%json_results%</script> | 885 <script id="results-json" type="application/json">%json_results%</script> |
| 886 <script id="units-json" type="application/json">%json_units%</script> | 886 <script id="units-json" type="application/json">%json_units%</script> |
| 887 </body> | 887 </body> |
| 888 </html> | 888 </html> |
| OLD | NEW |
