Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2170073002: Fix check failure when an offscreen element has animated background and first-line style (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rjwright, shans, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix check failure when an offscreen element has animated background and first-line style BUG=629718 Committed: https://crrev.com/2bcfe2b95a1f4c4d7fb48d63c877a0b7f48b25d6 Cr-Commit-Position: refs/heads/master@{#406985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen-firstline.html View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen-firstline-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Xianzhu
4 years, 5 months ago (2016-07-21 21:18:41 UTC) #4
chrishtr
lgtm
4 years, 5 months ago (2016-07-21 23:13:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170073002/1
4 years, 5 months ago (2016-07-21 23:14:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 23:19:25 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 23:21:17 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2bcfe2b95a1f4c4d7fb48d63c877a0b7f48b25d6
Cr-Commit-Position: refs/heads/master@{#406985}

Powered by Google App Engine
This is Rietveld 408576698