Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

Issue 2170073002: Fix check failure when an offscreen element has animated background and first-line style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ight reserved. 3 * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ight reserved.
4 * Copyright (C) 2010 Google Inc. All rights reserved. 4 * Copyright (C) 2010 Google Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 2049 matching lines...) Expand 10 before | Expand all | Expand 10 after
2060 if (RootInlineBox* firstRootBox = this->firstRootBox()) 2060 if (RootInlineBox* firstRootBox = this->firstRootBox())
2061 firstRootBox->setShouldDoFullPaintInvalidationRecursively(); 2061 firstRootBox->setShouldDoFullPaintInvalidationRecursively();
2062 } 2062 }
2063 2063
2064 PaintInvalidationReason LayoutBlockFlow::invalidatePaintIfNeeded(const PaintInva lidationState& paintInvalidationState) 2064 PaintInvalidationReason LayoutBlockFlow::invalidatePaintIfNeeded(const PaintInva lidationState& paintInvalidationState)
2065 { 2065 {
2066 if (containsFloats()) 2066 if (containsFloats())
2067 paintInvalidationState.paintingLayer().setNeedsPaintPhaseFloat(); 2067 paintInvalidationState.paintingLayer().setNeedsPaintPhaseFloat();
2068 2068
2069 PaintInvalidationReason reason = LayoutBlock::invalidatePaintIfNeeded(paintI nvalidationState); 2069 PaintInvalidationReason reason = LayoutBlock::invalidatePaintIfNeeded(paintI nvalidationState);
2070 if (reason == PaintInvalidationNone) 2070 if (reason == PaintInvalidationNone || reason == PaintInvalidationDelayedFul l)
2071 return reason; 2071 return reason;
2072
2072 RootInlineBox* line = firstRootBox(); 2073 RootInlineBox* line = firstRootBox();
2073 if (!line || !line->isFirstLineStyle()) 2074 if (!line || !line->isFirstLineStyle())
2074 return reason; 2075 return reason;
2075 // It's the RootInlineBox that paints the ::first-line background. Note that since it may be 2076 // It's the RootInlineBox that paints the ::first-line background. Note that since it may be
2076 // expensive to figure out if the first line is affected by any ::first-line selectors at all, 2077 // expensive to figure out if the first line is affected by any ::first-line selectors at all,
2077 // we just invalidate it unconditionally, since that's typically cheaper. 2078 // we just invalidate it unconditionally, since that's typically cheaper.
2078 invalidateDisplayItemClient(*line, reason); 2079 invalidateDisplayItemClient(*line, reason);
2079 return reason; 2080 return reason;
2080 } 2081 }
2081 2082
2082 } // namespace blink 2083 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen-firstline-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698