third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp - Issue 2170073002: Fix check failure when an offscreen element has animated background and first-line style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

Issue 2170073002: Fix check failure when an offscreen element has animated background and first-line style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen-firstline-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

index dba4a46ee7fe29714c2fdf057045d0c3ff91b4aa..ec3e9219dfd1bbb82f6d5a42c5c9e895573afb78 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

@@ -2067,8 +2067,9 @@ PaintInvalidationReason LayoutBlockFlow::invalidatePaintIfNeeded(const PaintInva

paintInvalidationState.paintingLayer().setNeedsPaintPhaseFloat();

PaintInvalidationReason reason = LayoutBlock::invalidatePaintIfNeeded(paintInvalidationState);

- if (reason == PaintInvalidationNone)

+ if (reason == PaintInvalidationNone || reason == PaintInvalidationDelayedFull)

return reason;

RootInlineBox* line = firstRootBox();

if (!line || !line->isFirstLineStyle())

return reason;