[system-health] Track amount of peak malloced memory in V8.

[system-health] Track amount of peak malloced memory in V8.

This patch adds v8:allocated_by_malloc:peak_size to the memory metric.

BUG=chromium:628239
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/cb90e4130adf57557b0d65ee0f2bf380dc69875b

[petrcermak, 2016-07-21 13:11:48]

petrcermak@chromium.org changed reviewers:
+ petrcermak@chromium.org

[petrcermak, 2016-07-21 13:11:49]

LGTM with a few comments.

Thanks,
Petr

https://codereview.chromium.org/2169873002/diff/1/tracing/tracing/metrics/sys...
File tracing/tracing/metrics/system_health/memory_metric.html (right):

https://codereview.chromium.org/2169873002/diff/1/tracing/tracing/metrics/sys...
tracing/tracing/metrics/system_health/memory_metric.html:289: if
(mallocDump.numerics['peak_size'] !== undefined) {
nit: no need for braces here

https://codereview.chromium.org/2169873002/diff/1/tracing/tracing/metrics/sys...
File tracing/tracing/metrics/system_health/memory_metric_test.html (right):

https://codereview.chromium.org/2169873002/diff/1/tracing/tracing/metrics/sys...
tracing/tracing/metrics/system_health/memory_metric_test.html:374:
addChildDump(isolateDumpA, 'malloc', {numerics: {
Could you also add one isolate with only "size" and one isolate with only
"peak_size"?

[ulan, 2016-07-21 13:47:07]

I added total peak size and v8 peak size to the expected test cases.

https://codereview.chromium.org/2169873002/diff/1/tracing/tracing/metrics/sys...
File tracing/tracing/metrics/system_health/memory_metric.html (right):

https://codereview.chromium.org/2169873002/diff/1/tracing/tracing/metrics/sys...
tracing/tracing/metrics/system_health/memory_metric.html:289: if
(mallocDump.numerics['peak_size'] !== undefined) {
On 2016/07/21 13:11:48, petrcermak wrote:
> nit: no need for braces here

Done.

https://codereview.chromium.org/2169873002/diff/1/tracing/tracing/metrics/sys...
File tracing/tracing/metrics/system_health/memory_metric_test.html (right):

https://codereview.chromium.org/2169873002/diff/1/tracing/tracing/metrics/sys...
tracing/tracing/metrics/system_health/memory_metric_test.html:374:
addChildDump(isolateDumpA, 'malloc', {numerics: {
On 2016/07/21 13:11:49, petrcermak wrote:
> Could you also add one isolate with only "size" and one isolate with only
> "peak_size"?

Done.

[ulan, 2016-07-21 13:49:06]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-07-21 13:49:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/2169873002/#ps40001
(title: "fix order")

[commit-bot: I haz the power, 2016-07-21 13:49:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 14:14:57]

Description was changed from

==========
[system-health] Track amount of peak malloced memory in V8.

This patch adds v8:allocated_by_malloc:peak_size to the memory metric.

BUG=chromium:628239
==========

to

==========
[system-health] Track amount of peak malloced memory in V8.

This patch adds v8:allocated_by_malloc:peak_size to the memory metric.

BUG=chromium:628239

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-21 14:14:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...