| Index: tracing/tracing/metrics/system_health/memory_metric.html
|
| diff --git a/tracing/tracing/metrics/system_health/memory_metric.html b/tracing/tracing/metrics/system_health/memory_metric.html
|
| index acccd77c6b37cc50f1abfaf9c04ecf8bf258752d..8396e3241d189c3d3f203e0ac5276cc2c372dca8 100644
|
| --- a/tracing/tracing/metrics/system_health/memory_metric.html
|
| +++ b/tracing/tracing/metrics/system_health/memory_metric.html
|
| @@ -275,15 +275,19 @@ tr.exportTo('tr.metrics.sh', function() {
|
| var v8Dump = processDump.getMemoryAllocatorDumpByFullName('v8');
|
| if (v8Dump !== undefined) {
|
| var allocatedByMalloc = 0;
|
| + var peakAllocatedByMalloc = 0;
|
| var hasMallocDump = false;
|
| v8Dump.children.forEach(function(isolateDump) {
|
| var mallocDump =
|
| isolateDump.getDescendantDumpByFullName('malloc');
|
| - if (mallocDump === undefined ||
|
| - mallocDump.numerics['effective_size'] === undefined) {
|
| + if (mallocDump === undefined)
|
| return;
|
| + if (mallocDump.numerics['effective_size'] !== undefined) {
|
| + allocatedByMalloc +=
|
| + mallocDump.numerics['effective_size'].value;
|
| }
|
| - allocatedByMalloc += mallocDump.numerics['effective_size'].value;
|
| + if (mallocDump.numerics['peak_size'] !== undefined)
|
| + peakAllocatedByMalloc += mallocDump.numerics['peak_size'].value;
|
| hasMallocDump = true;
|
| });
|
| if (hasMallocDump) {
|
| @@ -296,6 +300,15 @@ tr.exportTo('tr.metrics.sh', function() {
|
| descriptionPrefixBuilder:
|
| CHROME_VALUE_PROPERTIES['effective_size']
|
| });
|
| + addProcessScalar({
|
| + source: 'reported_by_chrome',
|
| + component: ['v8', 'allocated_by_malloc'],
|
| + property: 'peak_size',
|
| + value: peakAllocatedByMalloc,
|
| + unit: sizeInBytes_smallerIsBetter,
|
| + descriptionPrefixBuilder:
|
| + CHROME_VALUE_PROPERTIES['peak_size']
|
| + });
|
| }
|
| }
|
| },
|
| @@ -403,7 +416,11 @@ tr.exportTo('tr.metrics.sh', function() {
|
| 'locked_size': buildChromeValueDescriptionPrefix.bind(undefined, {
|
| userFriendlyPropertyName: 'locked (pinned) size',
|
| componentPreposition: 'of'
|
| - })
|
| + }),
|
| + 'peak_size': buildChromeValueDescriptionPrefix.bind(undefined, {
|
| + userFriendlyPropertyName: 'peak size',
|
| + componentPreposition: 'of'
|
| + }),
|
| };
|
|
|
| /**
|
|
|