Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: tracing/tracing/metrics/system_health/memory_metric_test.html

Issue 2169873002: [system-health] Track amount of peak malloced memory in V8. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: fix order Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/system_health/memory_metric.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/system_health/memory_metric_test.html
diff --git a/tracing/tracing/metrics/system_health/memory_metric_test.html b/tracing/tracing/metrics/system_health/memory_metric_test.html
index f70dd2d02680d94aba787264e259cc8c8401266c..680ece8a72c2ca59d6cfaa34e2cbf408b8c0b159 100644
--- a/tracing/tracing/metrics/system_health/memory_metric_test.html
+++ b/tracing/tracing/metrics/system_health/memory_metric_test.html
@@ -371,9 +371,23 @@ tr.b.unittest.testSuite(function() {
var v8Dump = newAllocatorDump(pmdRendererA2, 'v8',
{numerics: {size: 650}});
var isolateDumpA = addChildDump(v8Dump, 'isolate_A');
- addChildDump(isolateDumpA, 'malloc', {numerics: {size: 1 }});
+ addChildDump(isolateDumpA, 'malloc', {numerics: {
+ size: 1,
+ peak_size: 2
+ }});
var isolateDumpB = addChildDump(v8Dump, 'isolate_B');
- addChildDump(isolateDumpB, 'malloc', {numerics: {size: 10 }});
+ addChildDump(isolateDumpB, 'malloc', {numerics: {
+ size: 10,
+ peak_size: 20
+ }});
+ var isolateDumpC = addChildDump(v8Dump, 'isolate_C');
+ addChildDump(isolateDumpC, 'malloc', {numerics: {
+ size: 100,
+ }});
+ var isolateDumpD = addChildDump(v8Dump, 'isolate_D');
+ addChildDump(isolateDumpD, 'malloc', {numerics: {
+ peak_size: 200,
+ }});
return [partitionAllocDump, v8Dump];
})();
var pmdRendererB2 = addProcessMemoryDump(gmd2, pRendererB, {ts: 40});
@@ -463,6 +477,13 @@ tr.b.unittest.testSuite(function() {
description: 'total size of all allocated objects reported by Chrome ' +
'for all processes in Chrome'
},
+ 'memory:chrome:all_processes:reported_by_chrome:peak_size':
+ {
+ value: [0, 2 + 20 + 200, 0, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'total peak size reported by Chrome for all ' +
+ 'processes in Chrome'
+ },
'memory:chrome:all_processes:reported_by_chrome:gpu:effective_size': {
value: [30, 0, 300, 0],
unit: sizeInBytes_smallerIsBetter,
@@ -501,11 +522,18 @@ tr.b.unittest.testSuite(function() {
},
'memory:chrome:all_processes:reported_by_chrome:v8:allocated_by_malloc:effective_size':
{
- value: [0, 1 + 10, 0, 0],
+ value: [0, 1 + 10 + 100, 0, 0],
unit: sizeInBytes_smallerIsBetter,
description: 'effective size of objects allocated by malloc for v8 ' +
'in all processes in Chrome'
},
+ 'memory:chrome:all_processes:reported_by_chrome:v8:allocated_by_malloc:peak_size':
+ {
+ value: [0, 2 + 20 + 200, 0, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of objects allocated by malloc for v8 ' +
+ 'in all processes in Chrome'
+ },
'memory:chrome:all_processes:reported_by_chrome:v8:effective_size': {
value: [0, 650 + 970 + 111, 0, 4e5],
unit: sizeInBytes_smallerIsBetter,
@@ -518,6 +546,12 @@ tr.b.unittest.testSuite(function() {
description: 'size of all objects allocated by v8 in all processes ' +
'in Chrome'
},
+ 'memory:chrome:all_processes:reported_by_chrome:v8:peak_size':
+ {
+ value: [0, 2 + 20 + 200, 0, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of v8 in all processes in Chrome'
+ },
'memory:chrome:browser_process:process_count': {
value: [1, 1, 1, 1],
unit: unitlessNumber_smallerIsBetter,
@@ -599,6 +633,13 @@ tr.b.unittest.testSuite(function() {
description: 'total size of all allocated objects reported by ' +
'Chrome for renderer processes in Chrome'
},
+ 'memory:chrome:renderer_processes:reported_by_chrome:peak_size':
+ {
+ value: [0, 2 + 20 + 200, 0, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'total peak size reported by Chrome ' +
+ 'for renderer processes in Chrome'
+ },
'memory:chrome:renderer_processes:reported_by_chrome:malloc:effective_size':
{
value: [16, 0, 0, 0],
@@ -622,11 +663,18 @@ tr.b.unittest.testSuite(function() {
},
'memory:chrome:renderer_processes:reported_by_chrome:v8:allocated_by_malloc:effective_size':
{
- value: [0, 1 + 10, 0, 0],
+ value: [0, 1 + 10 + 100, 0, 0],
unit: sizeInBytes_smallerIsBetter,
description: 'effective size of objects allocated by malloc for v8 ' +
'in renderer processes in Chrome'
},
+ 'memory:chrome:renderer_processes:reported_by_chrome:v8:allocated_by_malloc:peak_size':
+ {
+ value: [0, 2 + 20 + 200, 0, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of objects allocated by malloc for v8 ' +
+ 'in renderer processes in Chrome'
+ },
'memory:chrome:renderer_processes:reported_by_chrome:v8:effective_size': {
value: [0, 650 + 970, 0, 4e5],
unit: sizeInBytes_smallerIsBetter,
@@ -639,6 +687,12 @@ tr.b.unittest.testSuite(function() {
description: 'size of all objects allocated by v8 in renderer ' +
'processes in Chrome'
},
+ 'memory:chrome:renderer_processes:reported_by_chrome:v8:peak_size':
+ {
+ value: [0, 2 + 20 + 200, 0, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of v8 in renderer processes in Chrome'
+ },
'memory:chrome:unknown_processes:process_count': {
value: [0, 1, 0, 0],
unit: unitlessNumber_smallerIsBetter,
@@ -1463,7 +1517,10 @@ tr.b.unittest.testSuite(function() {
size: 67108864
}});
var isolateDump = addChildDump(v8Dump, 'isolate');
- addChildDump(isolateDump, 'malloc', {numerics: {size: 1 }});
+ addChildDump(isolateDump, 'malloc', {numerics: {
+ size: 1,
+ peak_size: 2
+ }});
return [mallocDump, v8Dump];
})();
pmdBrowser6.vmRegions = VMRegionClassificationNode.fromRegions([
@@ -1533,6 +1590,13 @@ tr.b.unittest.testSuite(function() {
description: 'total size of all allocated objects reported by Chrome ' +
'for all processes in WebView'
},
+ 'memory:webview:all_processes:reported_by_chrome:peak_size':
+ {
+ value: [0, 2],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'total peak size reported by Chrome for all ' +
+ 'processes in WebView'
+ },
'memory:webview:all_processes:reported_by_chrome:malloc:effective_size': {
value: [2, 16384],
unit: sizeInBytes_smallerIsBetter,
@@ -1545,6 +1609,13 @@ tr.b.unittest.testSuite(function() {
description: 'effective size of objects allocated by malloc for v8 ' +
'in all processes in WebView'
},
+ 'memory:webview:all_processes:reported_by_chrome:v8:allocated_by_malloc:peak_size':
+ {
+ value: [0, 2],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of objects allocated by malloc for v8 ' +
+ 'in all processes in WebView'
+ },
'memory:webview:all_processes:reported_by_chrome:v8:effective_size': {
value: [4, 67108864],
unit: sizeInBytes_smallerIsBetter,
@@ -1564,6 +1635,12 @@ tr.b.unittest.testSuite(function() {
description: 'size of all objects allocated by v8 in all processes ' +
'in WebView'
},
+ 'memory:webview:all_processes:reported_by_chrome:v8:peak_size':
+ {
+ value: [0, 2],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of v8 in all processes in WebView'
+ },
'memory:webview:all_processes:reported_by_os:private_dirty_size': {
value: [65536],
unit: sizeInBytes_smallerIsBetter,
@@ -1657,6 +1734,13 @@ tr.b.unittest.testSuite(function() {
description: 'total size of code and metadata reported by Chrome ' +
'for the browser process in WebView'
},
+ 'memory:webview:browser_process:reported_by_chrome:peak_size':
+ {
+ value: [0, 2],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'total peak size reported by Chrome ' +
+ 'for the browser process in WebView'
+ },
'memory:webview:browser_process:reported_by_chrome:malloc:effective_size': {
value: [2, 16384],
unit: sizeInBytes_smallerIsBetter,
@@ -1669,6 +1753,13 @@ tr.b.unittest.testSuite(function() {
description: 'effective size of objects allocated by malloc for v8 ' +
'in the browser process in WebView'
},
+ 'memory:webview:browser_process:reported_by_chrome:v8:allocated_by_malloc:peak_size':
+ {
+ value: [0, 2],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of objects allocated by malloc for v8 ' +
+ 'in the browser process in WebView'
+ },
'memory:webview:browser_process:reported_by_chrome:v8:effective_size': {
value: [4, 67108864],
unit: sizeInBytes_smallerIsBetter,
@@ -1688,6 +1779,12 @@ tr.b.unittest.testSuite(function() {
description: 'size of v8 code and metadata in the browser process ' +
'in WebView'
},
+ 'memory:webview:browser_process:reported_by_chrome:v8:peak_size':
+ {
+ value: [0, 2],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of v8 in the browser process in WebView'
+ },
'memory:webview:browser_process:reported_by_os:private_dirty_size': {
value: [65536],
unit: sizeInBytes_smallerIsBetter,
« no previous file with comments | « tracing/tracing/metrics/system_health/memory_metric.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698