Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2169673003: Move bindings tooling scripts to Tools/Scripts/webkitpy/bindings (Closed)

Created:
4 years, 5 months ago by bashi
Modified:
4 years, 5 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, Dirk Pranke, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@change-test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move bindings tooling scripts to Tools/Scripts/webkitpy/bindings These scripts are not a part of code generator so it would be better to put them in Tools/Scripts/webkitpy/bindings. BUG=617899 Committed: https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b Cr-Commit-Position: refs/heads/master@{#406957}

Patch Set 1 #

Patch Set 2 : Move test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1531 lines) Patch
D third_party/WebKit/Source/bindings/scripts/collect_idls_into_json.py View 1 chunk +0 lines, -432 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/generate_idl_diff.py View 1 chunk +0 lines, -184 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/generate_idl_diff_test.py View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/print_idl_diff.py View 1 chunk +0 lines, -433 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/test_collect_idls_into_json.py View 1 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/testdata/new_blink_idls.json View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/testdata/old_blink_idls.json View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/Source/bindings/scripts/testdata/test_filepath.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/bindings/scripts/testdata/test_interface.idl View 1 chunk +0 lines, -9 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/collect_idls_into_json.py View 1 chunk +9 lines, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/collect_idls_into_json_test.py View 1 4 chunks +13 lines, -11 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/generate_idl_diff.py View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/generate_idl_diff_test.py View 1 chunk +8 lines, -9 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/print_idl_diff.py View 2 chunks +9 lines, -6 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/new_blink_idls.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/old_blink_idls.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/test_filepath.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/test_interface.idl View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Issue 2166223002 Patch 1

Messages

Total messages: 15 (9 generated)
bashi
PTAL? Also fixed pylint errors and test failures (tests were broken...)
4 years, 5 months ago (2016-07-21 08:56:46 UTC) #6
Yuki
lgtm
4 years, 5 months ago (2016-07-21 09:02:19 UTC) #7
haraken
LGTM
4 years, 5 months ago (2016-07-21 09:02:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169673003/20001
4 years, 5 months ago (2016-07-21 21:38:09 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 21:46:18 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:48:18 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e1b1fb569a15770e39c140a812bb8edae58ce11b
Cr-Commit-Position: refs/heads/master@{#406957}

Powered by Google App Engine
This is Rietveld 408576698