third_party/WebKit/Tools/Scripts/webkitpy/bindings/print_idl_diff.py - Issue 2169673003: Move bindings tooling scripts to Tools/Scripts/webkitpy/bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/bindings/print_idl_diff.py

Issue 2169673003: Move bindings tooling scripts to Tools/Scripts/webkitpy/bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@change-test

Patch Set: Move test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/bindings/generate_idl_diff_test.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/bindings/testdata/new_blink_idls.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/bindings/print_idl_diff.py

diff --git a/third_party/WebKit/Source/bindings/scripts/print_idl_diff.py b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/print_idl_diff.py

similarity index 96%

rename from third_party/WebKit/Source/bindings/scripts/print_idl_diff.py

rename to third_party/WebKit/Tools/Scripts/webkitpy/bindings/print_idl_diff.py

index 9a8deea5afa18c9330003a2ac6e97fce94a8019a..4330197859e8dd128c2d5e9383a357b12ebffd92 100755

--- a/third_party/WebKit/Source/bindings/scripts/print_idl_diff.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/print_idl_diff.py

@@ -16,16 +16,16 @@ Usage: print_idl_diff.py diff_file.json order

"""

from collections import OrderedDict

-import json

import sys

-from generate_idl_diff import load_json_file

-from generate_idl_diff import EXTATTRIBUTES_AND_MEMBER_TYPES

-from generate_idl_diff import DIFF_TAG

-from generate_idl_diff import DIFF_TAG_ADDED

-from generate_idl_diff import DIFF_TAG_DELETED

+from webkitpy.bindings.generate_idl_diff import load_json_file

+from webkitpy.bindings.generate_idl_diff import EXTATTRIBUTES_AND_MEMBER_TYPES

+from webkitpy.bindings.generate_idl_diff import DIFF_TAG

+from webkitpy.bindings.generate_idl_diff import DIFF_TAG_ADDED

+from webkitpy.bindings.generate_idl_diff import DIFF_TAG_DELETED

+# pylint: disable=W0105

"""Refer to the explanation of generate_idl_diff.py's input files.

The deffference between the input structure of generate_idl_diff.py and

that of print_diff.py is whether diffing tags are included or not.

@@ -190,8 +190,11 @@ def sort_interface_names_by_tags(interfaces):

"""

interface_list = interfaces.values()

removed, added, unspecified = group_by_tag(interface_list)

+ # pylint: disable=W0110

removed = map(lambda interface: interface['Name'], removed)

+ # pylint: disable=W0110

added = map(lambda interface: interface['Name'], added)

+ # pylint: disable=W0110

unspecified = map(lambda interface: interface['Name'], unspecified)

sorted_interface_names = removed + added + unspecified

return sorted_interface_names