Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2166223002: Rename Tools/Scripts/webkitpy/bindings/main.py to bindings_tests.py (Closed)

Created:
4 years, 5 months ago by bashi
Modified:
4 years, 5 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, Dirk Pranke, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Tools/Scripts/webkitpy/bindings/main.py to bindings_tests.py Some scripts in Source/bindings/scripts aren't executed while building chromium. These scripts should be placed in another place and Tools/Scripts/webkitpy/bindings is a good candidate to put tool-ish scripts. This CL renames main.py in the directory so that we can put other scripts in the directory. Also, I did some clean-ups to pass check-webkit-style. BUG=617899 Committed: https://crrev.com/5be6fa30d6a673a617bed7f02281cda1f9064765 Cr-Commit-Position: refs/heads/master@{#406796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -373 lines) Patch
M third_party/WebKit/Tools/Scripts/run-bindings-tests View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py View 3 chunks +11 lines, -14 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py View 1 chunk +0 lines, -358 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
bashi
PTAL? I'm planning to move collect_idls_into_json.py and generate_idl_diff.py to Tools/Scripts/webkitpy/bindings.
4 years, 5 months ago (2016-07-21 06:08:48 UTC) #4
Yuki
lgtm
4 years, 5 months ago (2016-07-21 06:14:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166223002/1
4 years, 5 months ago (2016-07-21 07:11:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 07:16:13 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 07:17:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5be6fa30d6a673a617bed7f02281cda1f9064765
Cr-Commit-Position: refs/heads/master@{#406796}

Powered by Google App Engine
This is Rietveld 408576698