Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 216963002: Add missing lazy deopt point for the TransitionElementsKind instruction. (Closed)

Created:
6 years, 9 months ago by Jarin
Modified:
6 years, 8 months ago
Reviewers:
mvstanton, Yang
CC:
v8-dev
Visibility:
Public.

Description

Add missing lazy deopt point for the TransitionElementsKind instruction. R=mvstanton@chromium.org, yangguo@chromium.org BUG=357105 TEST=test/mjsunit/regress/regress-357105.js LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -30 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-357105.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jarin
6 years, 9 months ago (2014-03-28 13:02:45 UTC) #1
Jarin
6 years, 8 months ago (2014-03-31 06:40:36 UTC) #2
mvstanton
LGTM.
6 years, 8 months ago (2014-03-31 07:14:51 UTC) #3
Jarin
6 years, 8 months ago (2014-03-31 11:59:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20347 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698