Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 216963002: Add missing lazy deopt point for the TransitionElementsKind instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4300 matching lines...) Expand 10 before | Expand all | Expand 10 after
4311 __ j(not_equal, &not_applicable); 4311 __ j(not_equal, &not_applicable);
4312 if (IsSimpleMapChangeTransition(from_kind, to_kind)) { 4312 if (IsSimpleMapChangeTransition(from_kind, to_kind)) {
4313 Register new_map_reg = ToRegister(instr->new_map_temp()); 4313 Register new_map_reg = ToRegister(instr->new_map_temp());
4314 __ Move(new_map_reg, to_map, RelocInfo::EMBEDDED_OBJECT); 4314 __ Move(new_map_reg, to_map, RelocInfo::EMBEDDED_OBJECT);
4315 __ movp(FieldOperand(object_reg, HeapObject::kMapOffset), new_map_reg); 4315 __ movp(FieldOperand(object_reg, HeapObject::kMapOffset), new_map_reg);
4316 // Write barrier. 4316 // Write barrier.
4317 ASSERT_NE(instr->temp(), NULL); 4317 ASSERT_NE(instr->temp(), NULL);
4318 __ RecordWriteField(object_reg, HeapObject::kMapOffset, new_map_reg, 4318 __ RecordWriteField(object_reg, HeapObject::kMapOffset, new_map_reg,
4319 ToRegister(instr->temp()), kDontSaveFPRegs); 4319 ToRegister(instr->temp()), kDontSaveFPRegs);
4320 } else { 4320 } else {
4321 ASSERT(object_reg.is(rax));
4321 ASSERT(ToRegister(instr->context()).is(rsi)); 4322 ASSERT(ToRegister(instr->context()).is(rsi));
4322 PushSafepointRegistersScope scope(this); 4323 PushSafepointRegistersScope scope(this);
4323 if (!object_reg.is(rax)) {
4324 __ movp(rax, object_reg);
4325 }
4326 __ Move(rbx, to_map); 4324 __ Move(rbx, to_map);
4327 bool is_js_array = from_map->instance_type() == JS_ARRAY_TYPE; 4325 bool is_js_array = from_map->instance_type() == JS_ARRAY_TYPE;
4328 TransitionElementsKindStub stub(from_kind, to_kind, is_js_array); 4326 TransitionElementsKindStub stub(from_kind, to_kind, is_js_array);
4329 __ CallStub(&stub); 4327 __ CallStub(&stub);
4330 RecordSafepointWithRegisters( 4328 RecordSafepointWithLazyDeopt(instr, RECORD_SAFEPOINT_WITH_REGISTERS, 0);
4331 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt);
4332 } 4329 }
4333 __ bind(&not_applicable); 4330 __ bind(&not_applicable);
4334 } 4331 }
4335 4332
4336 4333
4337 void LCodeGen::DoTrapAllocationMemento(LTrapAllocationMemento* instr) { 4334 void LCodeGen::DoTrapAllocationMemento(LTrapAllocationMemento* instr) {
4338 Register object = ToRegister(instr->object()); 4335 Register object = ToRegister(instr->object());
4339 Register temp = ToRegister(instr->temp()); 4336 Register temp = ToRegister(instr->temp());
4340 Label no_memento_found; 4337 Label no_memento_found;
4341 __ TestJSArrayForAllocationMemento(object, temp, &no_memento_found); 4338 __ TestJSArrayForAllocationMemento(object, temp, &no_memento_found);
(...skipping 1249 matching lines...) Expand 10 before | Expand all | Expand 10 after
5591 FixedArray::kHeaderSize - kPointerSize)); 5588 FixedArray::kHeaderSize - kPointerSize));
5592 __ bind(&done); 5589 __ bind(&done);
5593 } 5590 }
5594 5591
5595 5592
5596 #undef __ 5593 #undef __
5597 5594
5598 } } // namespace v8::internal 5595 } } // namespace v8::internal
5599 5596
5600 #endif // V8_TARGET_ARCH_X64 5597 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698