Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 216963002: Add missing lazy deopt point for the TransitionElementsKind instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/mjsunit/regress/regress-357105.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2225 matching lines...) Expand 10 before | Expand all | Expand 10 after
2236 ASSERT(instr->value()->representation().IsTagged()); 2236 ASSERT(instr->value()->representation().IsTagged());
2237 2237
2238 LStoreKeyedGeneric* result = 2238 LStoreKeyedGeneric* result =
2239 new(zone()) LStoreKeyedGeneric(context, object, key, value); 2239 new(zone()) LStoreKeyedGeneric(context, object, key, value);
2240 return MarkAsCall(result, instr); 2240 return MarkAsCall(result, instr);
2241 } 2241 }
2242 2242
2243 2243
2244 LInstruction* LChunkBuilder::DoTransitionElementsKind( 2244 LInstruction* LChunkBuilder::DoTransitionElementsKind(
2245 HTransitionElementsKind* instr) { 2245 HTransitionElementsKind* instr) {
2246 LOperand* object = UseRegister(instr->object());
2247 if (IsSimpleMapChangeTransition(instr->from_kind(), instr->to_kind())) { 2246 if (IsSimpleMapChangeTransition(instr->from_kind(), instr->to_kind())) {
2248 LOperand* object = UseRegister(instr->object()); 2247 LOperand* object = UseRegister(instr->object());
2249 LOperand* new_map_reg = TempRegister(); 2248 LOperand* new_map_reg = TempRegister();
2250 LOperand* temp_reg = TempRegister(); 2249 LOperand* temp_reg = TempRegister();
2251 LTransitionElementsKind* result = new(zone()) LTransitionElementsKind( 2250 LTransitionElementsKind* result = new(zone()) LTransitionElementsKind(
2252 object, NULL, new_map_reg, temp_reg); 2251 object, NULL, new_map_reg, temp_reg);
2253 return result; 2252 return result;
2254 } else { 2253 } else {
2254 LOperand* object = UseFixed(instr->object(), rax);
2255 LOperand* context = UseFixed(instr->context(), rsi); 2255 LOperand* context = UseFixed(instr->context(), rsi);
2256 LTransitionElementsKind* result = 2256 LTransitionElementsKind* result =
2257 new(zone()) LTransitionElementsKind(object, context, NULL, NULL); 2257 new(zone()) LTransitionElementsKind(object, context, NULL, NULL);
2258 return AssignPointerMap(result); 2258 return MarkAsCall(result, instr);
2259 } 2259 }
2260 } 2260 }
2261 2261
2262 2262
2263 LInstruction* LChunkBuilder::DoTrapAllocationMemento( 2263 LInstruction* LChunkBuilder::DoTrapAllocationMemento(
2264 HTrapAllocationMemento* instr) { 2264 HTrapAllocationMemento* instr) {
2265 LOperand* object = UseRegister(instr->object()); 2265 LOperand* object = UseRegister(instr->object());
2266 LOperand* temp = TempRegister(); 2266 LOperand* temp = TempRegister();
2267 LTrapAllocationMemento* result = 2267 LTrapAllocationMemento* result =
2268 new(zone()) LTrapAllocationMemento(object, temp); 2268 new(zone()) LTrapAllocationMemento(object, temp);
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
2589 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2589 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2590 LOperand* object = UseRegister(instr->object()); 2590 LOperand* object = UseRegister(instr->object());
2591 LOperand* index = UseTempRegister(instr->index()); 2591 LOperand* index = UseTempRegister(instr->index());
2592 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2592 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2593 } 2593 }
2594 2594
2595 2595
2596 } } // namespace v8::internal 2596 } } // namespace v8::internal
2597 2597
2598 #endif // V8_TARGET_ARCH_X64 2598 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/mjsunit/regress/regress-357105.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698