[Material][Mac] Fixed Bookmark Items Highlight Issues

[Material][Mac] Fixed Bookmark Items Highlight Issues

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187, 628204
Committed: https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309
Cr-Commit-Position: refs/heads/master@{#407032}

[spqchan, 2016-07-20 21:30:28]

Patchset #3 (id:40001) has been deleted

[spqchan, 2016-07-20 21:37:22]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-07-20 21:37:22]

Hey Jayson

I've been getting a lot of MD bookmark bugs. Most of it is caused
by how we highlight the bookmark items in MD with setHighlighted:

The problem is that our highlight logic is either missing edge cases or 
conflicts with the not MD-exclusive bookmark items logic.

I could fix it one by one, but I think it's easier if I just get rid of the
setHighlight: logic we've been using and just rely on the existing non
MD-exclusive one.

In my last bookmark CL (https://codereview.chromium.org/2134823002/) I made a
change so that we don't need to use setHighlighted: for the highlights to show
up.

WDYT about this? Let me know if there are any edge cases I'm missing out.

Thanks!

[spqchan, 2016-07-20 21:38:38]

Description was changed from

==========
[Material][Mac] Remove Bookmark Items MD Highlight logic

BUG=627722
==========

to

==========
[Material][Mac] Remove Bookmark Items MD setHighlighted Logic

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187
==========

[spqchan, 2016-07-20 21:50:09]

Description was changed from

==========
[Material][Mac] Remove Bookmark Items MD setHighlighted Logic

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187
==========

to

==========
[Material][Mac] Remove Bookmark Items MD setHighlighted Logic

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187, 628204
==========

[spqchan, 2016-07-21 00:17:18]

Description was changed from

==========
[Material][Mac] Remove Bookmark Items MD setHighlighted Logic

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187, 628204
==========

to

==========
[Material][Mac] Fixed Bookmark Items Highlight Issues

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187, 628204
==========

[shrike, 2016-07-22 00:54:43]

On 2016/07/20 21:37:22, spqchan wrote:
> Hey Jayson
> 
> I've been getting a lot of MD bookmark bugs. Most of it is caused
> by how we highlight the bookmark items in MD with setHighlighted:
> 
> The problem is that our highlight logic is either missing edge cases or 
> conflicts with the not MD-exclusive bookmark items logic.
> 
> I could fix it one by one, but I think it's easier if I just get rid of the
> setHighlight: logic we've been using and just rely on the existing non
> MD-exclusive one.
> 
> In my last bookmark CL (https://codereview.chromium.org/2134823002/) I made a
> change so that we don't need to use setHighlighted: for the highlights to show
> up.
> 
> WDYT about this? Let me know if there are any edge cases I'm missing out.
> 
> Thanks!

Hey Sarah,

Thank you for working to clean this up. These changes seem to leave bookmark
highlighting working correctly.

lgtm

[spqchan, 2016-07-22 01:15:50]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-07-22 01:15:50]

Np

+avi for OWNERS

[Avi (use Gerrit), 2016-07-22 01:17:20]

lgtm

ok

[spqchan, 2016-07-22 01:20:00]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-07-22 01:20:08]

thanks!

[commit-bot: I haz the power, 2016-07-22 01:20:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:37:44]

Description was changed from

==========
[Material][Mac] Fixed Bookmark Items Highlight Issues

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187, 628204
==========

to

==========
[Material][Mac] Fixed Bookmark Items Highlight Issues

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187, 628204
==========

[commit-bot: I haz the power, 2016-07-22 03:37:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 03:39:51]

Description was changed from

==========
[Material][Mac] Fixed Bookmark Items Highlight Issues

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187, 628204
==========

to

==========
[Material][Mac] Fixed Bookmark Items Highlight Issues

Remove calls to setHighlighted: for MD bookmark items.
Ensure that the items aren't highlighted when they are not enabled

BUG=627722, 628187, 628204

Committed: https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309
Cr-Commit-Position: refs/heads/master@{#407032}
==========

[commit-bot: I haz the power, 2016-07-22 03:39:52]

Patchset 2 (id:??) landed as
https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309
Cr-Commit-Position: refs/heads/master@{#407032}