Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/ui/cocoa/gradient_button_cell.mm

Issue 2169623002: [Material][Mac] Fixed Bookmark Items Highlight Issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No highlight if it's disabled Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/gradient_button_cell.mm
diff --git a/chrome/browser/ui/cocoa/gradient_button_cell.mm b/chrome/browser/ui/cocoa/gradient_button_cell.mm
index cabd8cc6fec106710300f07faab3dfb962ba30f2..0709ad34d03dbc63391384f4184ceae20ff05acc 100644
--- a/chrome/browser/ui/cocoa/gradient_button_cell.mm
+++ b/chrome/browser/ui/cocoa/gradient_button_cell.mm
@@ -346,8 +346,6 @@ static const NSTimeInterval kAnimationContinuousCycleDuration = 0.4;
[super setShowsBorderOnlyWhileMouseInside:showOnly];
if (showOnly) {
[self updateTrackingAreas];
- if ([self tag] == kMaterialStandardButtonTypeWithLimitedClickFeedback)
- [self setHighlighted:isMouseInside_];
} else {
if (trackingArea_) {
[[self controlView] removeTrackingArea:trackingArea_];
@@ -585,8 +583,8 @@ static const NSTimeInterval kAnimationContinuousCycleDuration = 0.4;
innerPath:&innerPath
clipPath:NULL];
- BOOL pressed = ([((NSControl*)[self controlView]) isEnabled] &&
- [self isHighlighted]);
+ BOOL enabled = [((NSControl*)[self controlView]) isEnabled];
+ BOOL pressed = enabled && [self isHighlighted];
NSWindow* window = [controlView window];
const ui::ThemeProvider* themeProvider = [window themeProvider];
BOOL active = [window isKeyWindow] || [window isMainWindow];
@@ -598,7 +596,8 @@ static const NSTimeInterval kAnimationContinuousCycleDuration = 0.4;
// |showsBorderOnlyWhileMouseInside| is true.
BOOL hasMaterialHighlight =
[self tag] == kMaterialStandardButtonTypeWithLimitedClickFeedback &&
- ![self showsBorderOnlyWhileMouseInside];
+ ![self showsBorderOnlyWhileMouseInside] &&
+ enabled;
if (([self isBordered] && ![self showsBorderOnlyWhileMouseInside]) ||
pressed || [self isMouseInside] || [self isContinuousPulsing] ||
hasMaterialHighlight) {
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698