chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm - Issue 2169623002: [Material][Mac] Fixed Bookmark Items Highlight Issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

Issue 2169623002: [Material][Mac] Fixed Bookmark Items Highlight Issues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: No highlight if it's disabled Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm ('k') | chrome/browser/ui/cocoa/gradient_button_cell.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

index d950688bea745724d29cd38b477bc62205f52430..f402857a3150840a7cd0c5c6fd09f3394c05d04d 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

@@ -360,16 +360,6 @@ BookmarkButton* gDraggedButton = nil; // Weak

[delegate_ mouseExitedButton:self event:event];

}

-- (void)mouseDown:(NSEvent*)theEvent {

- // Clicking on a bookmark button in Material Design should highlight it.

- const int kCellTag = [[self cell] tag];

- if (kCellTag == kMaterialStandardButtonTypeWithLimitedClickFeedback &&

- [self isEnabled]) {

- [self highlight:YES];

- }

- [super mouseDown:theEvent];

- (void)mouseMoved:(NSEvent*)theEvent {

if ([delegate_ respondsToSelector:@selector(mouseMoved:)])

[id(delegate_) mouseMoved:theEvent];

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm ('k') | chrome/browser/ui/cocoa/gradient_button_cell.mm » ('j') | no next file with comments »