[keys] Postpone shadowed key checking in the KeyAccumulator

[keys] Postpone shadowed key checking in the KeyAccumulator

Only start checking if new keys are shadowed after the first prototype has added
non-enumerable shadow keys. This helps minimally in some corner cases if there
are few enumerable properties on the prototype compared to the receiver.

BUG=chromium:628173
Committed: https://crrev.com/211615d41ea989395f52c3f2cc453eb3a47eeb5f
Cr-Commit-Position: refs/heads/master@{#37940}

[Camillo Bruni, 2016-07-20 16:13:48]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 16:13:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 16:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 16:38:00]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-07-21 09:05:34]

Description was changed from

==========
[keys] Postpone shadowed key checking in the KeyAccumulator

Only start checking if new keys are shadowed after the first prototype has added
non-enumerable shadow keys. This helps minimally in some corner cases if there
are few enumerable properties on the prototype compared to the receiver.

BUG=
==========

to

==========
[keys] Postpone shadowed key checking in the KeyAccumulator

Only start checking if new keys are shadowed after the first prototype has added
non-enumerable shadow keys. This helps minimally in some corner cases if there
are few enumerable properties on the prototype compared to the receiver.

BUG=chromium:628173
==========

[Camillo Bruni, 2016-07-21 09:07:24]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2016-07-21 09:07:25]

PTAL some minor improvement for corner cases

[Jakob Kummerow, 2016-07-21 09:25:45]

lgtm

https://codereview.chromium.org/2169523002/diff/1/src/keys.h
File src/keys.h (right):

https://codereview.chromium.org/2169523002/diff/1/src/keys.h#newcode114
src/keys.h:114: // For all the keys on the first reciever adding a shadowing key
we can skip
nit: receiver

[Camillo Bruni, 2016-07-21 10:36:45]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-07-21 10:36:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2169523002/#ps20001
(title: "typo")

[commit-bot: I haz the power, 2016-07-21 10:36:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 11:05:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-21 11:06:30]

Description was changed from

==========
[keys] Postpone shadowed key checking in the KeyAccumulator

Only start checking if new keys are shadowed after the first prototype has added
non-enumerable shadow keys. This helps minimally in some corner cases if there
are few enumerable properties on the prototype compared to the receiver.

BUG=chromium:628173
==========

to

==========
[keys] Postpone shadowed key checking in the KeyAccumulator

Only start checking if new keys are shadowed after the first prototype has added
non-enumerable shadow keys. This helps minimally in some corner cases if there
are few enumerable properties on the prototype compared to the receiver.

BUG=chromium:628173

Committed: https://crrev.com/211615d41ea989395f52c3f2cc453eb3a47eeb5f
Cr-Commit-Position: refs/heads/master@{#37940}
==========

[commit-bot: I haz the power, 2016-07-21 11:06:31]

Patchset 2 (id:??) landed as
https://crrev.com/211615d41ea989395f52c3f2cc453eb3a47eeb5f
Cr-Commit-Position: refs/heads/master@{#37940}