Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: src/objects.cc

Issue 2169523002: [keys] Postpone shadowed key checking in the KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/keys.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index ad7df3765f14a2f9334a5970b565a137242e395d..a416e81a5f99cbc05fb10c39df2f513f288784b5 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -17526,7 +17526,7 @@ void Dictionary<Derived, Shape, Key>::CopyEnumKeysTo(
}
if (dictionary->IsDeleted(i)) continue;
if (is_shadowing_key) {
- accumulator->AddShadowKey(key);
+ accumulator->AddShadowingKey(key);
continue;
} else {
storage->set(properties, Smi::FromInt(i));
@@ -17566,7 +17566,7 @@ void Dictionary<Derived, Shape, Key>::CollectKeysTo(
if (raw_dict->IsDeleted(i)) continue;
PropertyDetails details = raw_dict->DetailsAt(i);
if ((details.attributes() & filter) != 0) {
- keys->AddShadowKey(k);
+ keys->AddShadowingKey(k);
continue;
}
if (filter & ONLY_ALL_CAN_READ) {
« no previous file with comments | « src/keys.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698