Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: src/elements.cc

Issue 2169523002: [keys] Postpone shadowed key checking in the KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/keys.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index 3cf8378162844a1fc00525e3ccacdb6f47406ac5..f58249b1518a8e49059a7576c48207eac700c6b5 100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -1327,7 +1327,7 @@ class DictionaryElementsAccessor
if (!dictionary->IsKey(isolate, raw_key)) continue;
uint32_t key = FilterKey(dictionary, i, raw_key, filter);
if (key == kMaxUInt32) {
- keys->AddShadowKey(raw_key);
+ keys->AddShadowingKey(raw_key);
continue;
}
elements->set(insertion_index, raw_key);
« no previous file with comments | « no previous file | src/keys.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698