[M53] 📰Stop clearing suggestions to show the RELOAD card.

[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831
TBR=bauerb@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)

[dgn, 2016-07-22 10:00:00]

Description was changed from

==========
[NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
==========

to

==========
[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
==========

[dgn, 2016-07-22 10:00:51]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org, mvanouwerkerk@chromium.org

[dgn, 2016-07-22 10:00:52]

PTAL. I partially reverted the changes from
https://codereview.chromium.org/2162093002 (Changing SnippetsArticleListItem to
SnippetsArticle) to be able merge this.

Cherry picking the above CL would also require cherry-picking
https://codereview.chromium.org/2122993003 to be able to merge cleanly.

[Michael van Ouwerkerk, 2016-07-22 10:04:07]

lgtm

[dgn, 2016-07-22 10:11:14]

Description was changed from

==========
[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
==========

to

==========
[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831
TBR=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
==========

[dgn, 2016-07-22 10:11:35]

Description was changed from

==========
[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831
TBR=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
==========

to

==========
[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831
TBR=bauerb@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
==========

[dgn, 2016-07-22 10:11:50]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2016-07-22 10:12:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 10:14:11]

Description was changed from

==========
[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831
TBR=bauerb@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
==========

to

==========
[M53][NTP Client] Stop clearing suggestions to show the RELOAD card.

We used to clear already loaded suggestions unconditionally when
receiving notifications of the service status having changed. During
startup we used to pull suggestions right away and get the status OK
notification afterwards, which cleared them. We now properly detect
and do nothing in that case.

BUG=626831
TBR=bauerb@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2166753003
Cr-Commit-Position: refs/heads/master@{#406837}
(cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626)
==========

[commit-bot: I haz the power, 2016-07-22 10:14:12]

Committed patchset #1 (id:1)

[gordanac, 2016-08-04 15:52:18]

gordana.cmiljanovic@imgtec.com changed reviewers:
+ Gordana.Cmiljanovic@imgtec.com

[gordanac, 2016-08-04 15:52:19]

https://codereview.chromium.org/2169393002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(right):

https://codereview.chromium.org/2169393002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:159:
List<SnippetArticleListItem> snippets = createDummySnippets();
I think you need to either merge https://codereview.chromium.org/2162093002 or
rename this to SnippetArticle.

Currently, M53 build fails with error:
../../chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:159:
error: cannot find symbol
        List<SnippetArticleListItem> snippets = createDummySnippets(); 
             ^

You can see more details in:
http://www.rt-rk.com/mips-buildbot/builders/Release%20branch%20build/builds/1...

https://codereview.chromium.org/2169393002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:166:
snippets.add(new SnippetArticleListItem("https://site.com/url1", "title1",
"pub1", "txt1",
Same as above.

[dgn, 2016-08-04 16:24:04]

dgn@chromium.org changed reviewers:
+ gordana.cmiljanovic@imgtec.com
- Gordana.Cmiljanovic@imgtec.com

[dgn, 2016-08-04 16:24:05]

https://codereview.chromium.org/2169393002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
(right):

https://codereview.chromium.org/2169393002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:159:
List<SnippetArticleListItem> snippets = createDummySnippets();
On 2016/08/04 15:52:19, gordanac wrote:
> I think you need to either merge https://codereview.chromium.org/2162093002 or
> rename this to SnippetArticle.
> 
> Currently, M53 build fails with error:
>
../../chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java:159:
> error: cannot find symbol
>         List<SnippetArticleListItem> snippets = createDummySnippets(); 
>              ^
> 
> You can see more details in:
>
http://www.rt-rk.com/mips-buildbot/builders/Release%20branch%20build/builds/1...

Oh no, sorry it slipped. Will send a CL ASAP