Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2162093002: Rename SnippetArticle to SnippetArticleListItem for consistency. (Closed)

Created:
4 years, 5 months ago by Michael van Ouwerkerk
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SnippetArticle to SnippetArticleListItem for consistency. BUG=616090 Committed: https://crrev.com/8281029c71e4a6302e806293d39a47502974f4ce Cr-Commit-Position: refs/heads/master@{#406524}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 5 months ago (2016-07-19 17:07:05 UTC) #4
Bernhard Bauer
LGTM, although we should start looking into using the final terminology ("content suggestions") instead of ...
4 years, 5 months ago (2016-07-20 08:26:07 UTC) #7
Michael van Ouwerkerk
Thanks. Agreed that we should settle on something more final, but currently the term "snippet" ...
4 years, 5 months ago (2016-07-20 09:26:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162093002/1
4 years, 5 months ago (2016-07-20 09:26:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 09:32:50 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 09:34:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8281029c71e4a6302e806293d39a47502974f4ce
Cr-Commit-Position: refs/heads/master@{#406524}

Powered by Google App Engine
This is Rietveld 408576698