Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2122993003: Remove unused Interests code. (Closed)

Created:
4 years, 5 months ago by PEConn
Modified:
4 years, 5 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused Interests code. It is unlikely that we'll use the Interests front-end code (though we may still use the back-end for a Cards experiment). BUG=not really TBR=bauerb@chromium.org Committed: https://crrev.com/8d8847effc68f904c377c627fe51c9b886a9d280 Cr-Commit-Position: refs/heads/master@{#404628}

Patch Set 1 #

Patch Set 2 : Forgot unit test target. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1559 lines) Patch
M chrome/android/java/res/layout/new_tab_page_view.xml View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 6 chunks +0 lines, -36 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 3 chunks +0 lines, -17 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsItemView.java View 1 chunk +0 lines, -243 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsService.java View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsView.java View 1 chunk +0 lines, -91 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/ntp/interests/InterestsServiceTest.java View 1 chunk +0 lines, -193 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/interests/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/interests/android/interests_service.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/interests/android/interests_service.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/interests/interests_fetcher.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/interests/interests_fetcher.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D chrome/browser/interests/interests_fetcher_unittest.cc View 1 chunk +0 lines, -206 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (13 generated)
PEConn
What do you think of removing the Interests front end code?
4 years, 5 months ago (2016-07-06 14:06:46 UTC) #3
Marc Treib
On 2016/07/06 14:06:46, PEConn1 wrote: > What do you think of removing the Interests front ...
4 years, 5 months ago (2016-07-06 14:10:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122993003/1
4 years, 5 months ago (2016-07-06 14:12:05 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/92061)
4 years, 5 months ago (2016-07-06 14:22:01 UTC) #8
PEConn
On 2016/07/06 14:10:28, Marc Treib wrote: > On 2016/07/06 14:06:46, PEConn1 wrote: > > What ...
4 years, 5 months ago (2016-07-06 15:42:52 UTC) #9
Marc Treib
On 2016/07/06 15:42:52, PEConn1 wrote: > On 2016/07/06 14:10:28, Marc Treib wrote: > > On ...
4 years, 5 months ago (2016-07-07 08:12:29 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122993003/20001
4 years, 5 months ago (2016-07-07 08:33:27 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/32409)
4 years, 5 months ago (2016-07-07 08:36:14 UTC) #14
Bernhard Bauer
LGTM
4 years, 5 months ago (2016-07-07 08:45:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122993003/20001
4 years, 5 months ago (2016-07-07 10:41:18 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/213489)
4 years, 5 months ago (2016-07-07 10:48:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122993003/20001
4 years, 5 months ago (2016-07-11 09:12:41 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 10:41:48 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 10:41:50 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 10:43:57 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d8847effc68f904c377c627fe51c9b886a9d280
Cr-Commit-Position: refs/heads/master@{#404628}

Powered by Google App Engine
This is Rietveld 408576698