Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make two tests more robust Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutText.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutText.cpp b/third_party/WebKit/Source/core/layout/LayoutText.cpp
index 217a32e7d488d0f6c70c7219adfd58456a803c81..21acd03db0bfd619f5bc420d01f1592a4c73a5a8 100644
--- a/third_party/WebKit/Source/core/layout/LayoutText.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutText.cpp
@@ -402,7 +402,7 @@ static IntRect ellipsisRectForBox(InlineTextBox* box, unsigned startPos, unsigne
return IntRect();
}
-void LayoutText::absoluteQuads(Vector<FloatQuad>& quads, ClippingOption option) const
+void LayoutText::quads(Vector<FloatQuad>& quads, ClippingOption option, LocalOrAbsoluteOption localOrAbsolute) const
{
for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {
FloatRect boundaries(box->calculateBoundaries());
@@ -416,13 +416,16 @@ void LayoutText::absoluteQuads(Vector<FloatQuad>& quads, ClippingOption option)
else
boundaries.setHeight(ellipsisRect.maxY() - boundaries.y());
}
- quads.append(localToAbsoluteQuad(boundaries));
+ if (localOrAbsolute == AbsoluteQuads)
+ quads.append(localToAbsoluteQuad(boundaries));
+ else
+ quads.append(boundaries);
}
}
void LayoutText::absoluteQuads(Vector<FloatQuad>& quads) const
{
- absoluteQuads(quads, NoClipping);
+ this->quads(quads, NoClipping, AbsoluteQuads);
}
void LayoutText::absoluteQuadsForRange(Vector<FloatQuad>& quads, unsigned start, unsigned end, bool useSelectionHeight)

Powered by Google App Engine
This is Rietveld 408576698