third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp - Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make two tests more robust Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/accessibility/svg-bounds-expected.txt ('K') | « third_party/WebKit/Source/core/layout/LayoutText.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h » ('j') | third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp b/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

index 5315569c8d8dde2ef373376f670a4bf14cf5260e..7947197e38196b6119c20006b7c58f81f7658a23 100644

--- a/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp

@@ -98,8 +98,7 @@ LayoutRect AbstractInlineTextBox::bounds() const

if (!m_inlineTextBox || !m_lineLayoutItem)

return LayoutRect();

- FloatRect boundaries(m_inlineTextBox->calculateBoundaries());

- return LayoutRect(m_lineLayoutItem.localToAbsoluteQuad(boundaries).enclosingBoundingBox());

+ return m_inlineTextBox->calculateBoundaries();

}

unsigned AbstractInlineTextBox::len() const