Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

Issue 2169273004: Switch all LayoutTests to use new accessibility relative bounding box API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make two tests more robust Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
index 423778cc2663ce7594710417605b8611800268f1..646d66abb2af8dea6f944e8a5d3efdd066c58e3a 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
@@ -68,6 +68,19 @@ LayoutRect AXInlineTextBox::elementRect() const
return m_inlineTextBox->bounds();
}
+void AXInlineTextBox::getRelativeBounds(AXObject** outContainer, FloatRect& outBoundsInContainer, SkMatrix44& outContainerTransform) const
+{
+ *outContainer = nullptr;
+ outBoundsInContainer = FloatRect();
+ outContainerTransform.setIdentity();
+
+ if (!m_inlineTextBox)
aboxhall 2016/07/28 18:40:43 Maybe a comment explaining the guarantees made by
dmazzoni 2016/07/28 21:43:16 I included a lot of documentation in AXObject.h, i
aboxhall 2016/07/28 22:13:10 It was more that I did a bit of a double take at r
+ return;
+
+ *outContainer = parentObject();
+ outBoundsInContainer = FloatRect(m_inlineTextBox->bounds());
+}
+
bool AXInlineTextBox::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReasons) const
{
AXObject* parent = parentObject();

Powered by Google App Engine
This is Rietveld 408576698