build/config/mac/sdk_info.py - Issue 2168873003: Query sdk-platform-path in build/config/mac/sdk_info.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/mac/sdk_info.py

Issue 2168873003: Query sdk-platform-path in build/config/mac/sdk_info.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/mac/sdk_info.py

diff --git a/build/config/mac/sdk_info.py b/build/config/mac/sdk_info.py

index 9a7d57a85f23dd7ba19762680e35c6b7d73a5b68..d4b12a9c1e1e1baaa0c728b8be4519d12a5efaaf 100644

--- a/build/config/mac/sdk_info.py

+++ b/build/config/mac/sdk_info.py

@@ -39,6 +39,8 @@ def FillSDKPathAndVersion(settings, platform, xcode_version):

'xcrun', '-sdk', platform, '--show-sdk-path']).strip()

settings['sdk_version'] = subprocess.check_output([

'xcrun', '-sdk', platform, '--show-sdk-version']).strip()

+ settings['sdk_platform_path'] = subprocess.check_output([

+ 'xcrun', '-sdk', platform, '--show-sdk-platform-path']).strip()

# TODO: unconditionally use --show-sdk-build-version once Xcode 7.2 or

# higher is required to build Chrome for iOS or OS X.

if xcode_version >= '0720':

« no previous file with comments | « build/config/ios/ios_sdk.gni ('k') | no next file » | no next file with comments »