Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216883008: Use tokenPos instead of line/col in the vm service. (Closed)

Created:
6 years, 8 months ago by turnidge
Modified:
6 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Use tokenPos instead of line/col in the vm service. Add line number information to the Script response. Parse line number information in the observatory. Update <script-ref> to take a pos argument Add a new <script-inset> element which shows a code snippet. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34528

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : gen js / handle multiple reloads #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1199 lines, -740 lines) Patch
M runtime/bin/resources_sources.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 6 chunks +45 lines, -21 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 187 chunks +388 lines, -306 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js.map View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 6 chunks +45 lines, -21 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 187 chunks +388 lines, -306 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js.map View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/elements.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_view.html View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html View 1 2 2 chunks +9 lines, -15 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_inset.html View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/stack_frame.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/elements.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_view.html View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html View 2 chunks +9 lines, -15 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.html View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/elements/script_inset.dart View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/elements/script_inset.html View 1 chunk +34 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/script_ref.dart View 1 2 2 chunks +38 lines, -9 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/stack_frame.html View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 1 2 4 chunks +46 lines, -10 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +1 line, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 2 4 chunks +52 lines, -7 lines 0 comments Download
M runtime/vm/service_test.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
6 years, 8 months ago (2014-03-28 19:43:49 UTC) #1
Cutch
lgtm with comments https://codereview.chromium.org/216883008/diff/20001/runtime/bin/vmservice/client/lib/src/elements/script_inset.dart File runtime/bin/vmservice/client/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/216883008/diff/20001/runtime/bin/vmservice/client/lib/src/elements/script_inset.dart#newcode21 runtime/bin/vmservice/client/lib/src/elements/script_inset.dart:21: loadStarted = false; Maybe add a ...
6 years, 8 months ago (2014-03-28 20:22:31 UTC) #2
turnidge
Committed patchset #3 manually as r34528 (presubmit successful).
6 years, 8 months ago (2014-03-28 21:24:43 UTC) #3
turnidge
6 years, 8 months ago (2014-03-28 21:36:26 UTC) #4
Message was sent while issue was closed. 
As discussed offline, I added reload-sharing code into the base ServiceObject to
avoid two simultaneous reload requests for the same object.

Powered by Google App Engine
This is Rietveld 408576698