Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html

Issue 216883008: Use tokenPos instead of line/col in the vm service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js / handle multiple reloads Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
diff --git a/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html b/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
index a1aefc6495cb9f6c4e5c2db9c6b3e502aa9574be..ca89f0071ba62295ec6ab12314d939ad3454643f 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
+++ b/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
@@ -2,6 +2,7 @@
<link rel="import" href="function_ref.html">
<link rel="import" href="isolate_ref.html">
<link rel="import" href="observatory_element.html">
+ <link rel="import" href="script_inset.html">
<link rel="import" href="script_ref.html">
</head>
<polymer-element name="isolate-summary" extends="observatory-element">
@@ -72,21 +73,14 @@
( <a href="{{ isolate.relativeHashLink('stacktrace') }}">stack trace</a> )
</div>
</div>
- <div class="row">
- <div class="col-md-3">
- </div>
- <div class="col-md-6">
- <template if="{{ isolate.topFrame != null }}">
- <function-ref ref="{{ isolate.topFrame['function'] }}"></function-ref>
- (<script-ref ref="{{ isolate.topFrame['script'] }}"
- line="{{ isolate.topFrame['line'] }}"></script-ref>)
- <br>
- <pre>{{ isolate.topFrame['line'] }} &nbsp; {{ isolate.topFrame['lineString'] }}</pre>
- </template>
- </div>
- <div class="col-md-3">
- </div>
- </div>
+ <template if="{{ isolate.topFrame != null }}">
+ <script-inset script="{{ isolate.topFrame['script'] }}"
+ pos="{{ isolate.topFrame['tokenPos'] }}">
+ <function-ref ref="{{ isolate.topFrame['function'] }}"></function-ref>
+ (<script-ref ref="{{ isolate.topFrame['script'] }}"
+ pos="{{ isolate.topFrame['tokenPos'] }}"></script-ref>)
+ </script-inset>
+ </template>
</template>
<script type="application/dart" src="isolate_summary.dart"></script>
</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698