runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html - Issue 216883008: Use tokenPos instead of line/col in the vm service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html

Issue 216883008: Use tokenPos instead of line/col in the vm service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js / handle multiple reloads Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_view.html ('k') | runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html

diff --git a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html

index a1aefc6495cb9f6c4e5c2db9c6b3e502aa9574be..ca89f0071ba62295ec6ab12314d939ad3454643f 100644

--- a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html

+++ b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html

@@ -2,6 +2,7 @@

+ <link rel="import" href="script_inset.html">

</head>

<polymer-element name="isolate-summary" extends="observatory-element">

@@ -72,21 +73,14 @@

( <a href="{{ isolate.relativeHashLink('stacktrace') }}">stack trace</a> )

</div>

- <div class="row">

- <div class="col-md-3">

- </div>

- <div class="col-md-6">

- <template if="{{ isolate.topFrame != null }}">

- <function-ref ref="{{ isolate.topFrame['function'] }}"></function-ref>

- (<script-ref ref="{{ isolate.topFrame['script'] }}"

- line="{{ isolate.topFrame['line'] }}"></script-ref>)

- <br>

- <pre>{{ isolate.topFrame['line'] }}   {{ isolate.topFrame['lineString'] }}</pre>

- </template>

- </div>

- <div class="col-md-3">

- </div>

+ <template if="{{ isolate.topFrame != null }}">

+ <script-inset script="{{ isolate.topFrame['script'] }}"

+ pos="{{ isolate.topFrame['tokenPos'] }}">

+ <function-ref ref="{{ isolate.topFrame['function'] }}"></function-ref>

+ (<script-ref ref="{{ isolate.topFrame['script'] }}"

+ pos="{{ isolate.topFrame['tokenPos'] }}"></script-ref>)

+ </script-inset>

+ </template>

</template>

</polymer-element>