Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2168733002: Splits debug_commands into aura and non-aura parts (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Splits debug_commands into aura and non-aura parts I ended up moving the aura parts directly into accelerator_controller_delegate_aura as it didn't seem worth an extra file as the code is always compiled (and isn't that much). BUG=626869 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2 Cr-Commit-Position: refs/heads/master@{#406748}

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : moar #

Patch Set 4 : moar #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -143 lines) Patch
M ash/accelerators/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_controller.cc View 1 2 5 chunks +2 lines, -18 lines 0 comments Download
M ash/accelerators/accelerator_controller_delegate_aura.cc View 1 2 3 11 chunks +97 lines, -0 lines 0 comments Download
M ash/accelerators/debug_commands.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/accelerators/debug_commands.cc View 5 chunks +23 lines, -105 lines 1 comment Download
M ash/aura/wm_root_window_controller_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_root_window_controller_aura.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ash/aura/wm_window_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_window_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/wm_root_window_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/wm_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/mus/window_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/debug_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/debug_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 2 chunks +14 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
sky
4 years, 5 months ago (2016-07-20 22:05:11 UTC) #2
James Cook
LGTM https://codereview.chromium.org/2168733002/diff/60001/ash/accelerators/debug_commands.cc File ash/accelerators/debug_commands.cc (right): https://codereview.chromium.org/2168733002/diff/60001/ash/accelerators/debug_commands.cc#newcode46 ash/accelerators/debug_commands.cc:46: void PrintWindowHierarchy(const WmWindow* active_window, Hooray! We'll be able ...
4 years, 5 months ago (2016-07-21 00:54:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168733002/60001
4 years, 5 months ago (2016-07-21 02:51:30 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-21 03:08:25 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:10:33 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2
Cr-Commit-Position: refs/heads/master@{#406748}

Powered by Google App Engine
This is Rietveld 408576698