Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2166793005: Moves accelerator code using common types to ash/common (Closed)

Created:
4 years, 5 months ago by sky
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, dcheng, tfarina, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@debug_commands
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves accelerator code using common types to ash/common BUG=612331 TEST=none R=jamescook@chromium.org TBR=jamescook@chromium.org Committed: https://crrev.com/de61f98917bb57f90490a730b23168b85722868d Cr-Commit-Position: refs/heads/master@{#406877}

Patch Set 1 #

Patch Set 2 : not relative #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -2639 lines) Patch
D ash/accelerators/accelerator_commands.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ash/accelerators/accelerator_commands.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M ash/accelerators/accelerator_commands_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/accelerators/accelerator_controller.h View 1 chunk +0 lines, -203 lines 0 comments Download
D ash/accelerators/accelerator_controller.cc View 1 chunk +0 lines, -836 lines 0 comments Download
D ash/accelerators/accelerator_controller_delegate.h View 1 chunk +0 lines, -50 lines 0 comments Download
M ash/accelerators/accelerator_controller_delegate_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_delegate_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/accelerators/accelerator_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/accelerators/accelerator_table.h View 1 chunk +0 lines, -261 lines 0 comments Download
D ash/accelerators/accelerator_table.cc View 1 chunk +0 lines, -529 lines 0 comments Download
D ash/accelerators/accelerator_table_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D ash/accelerators/debug_commands.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ash/accelerators/debug_commands.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D ash/accelerators/exit_warning_handler.h View 1 chunk +0 lines, -84 lines 0 comments Download
D ash/accelerators/exit_warning_handler.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M ash/accelerators/focus_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 3 chunks +12 lines, -12 lines 0 comments Download
A + ash/common/accelerators/accelerator_commands.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/accelerators/accelerator_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/accelerators/accelerator_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ash/common/accelerators/accelerator_controller.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + ash/common/accelerators/accelerator_controller_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/accelerators/accelerator_table.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/accelerators/accelerator_table.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/accelerators/accelerator_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/accelerators/debug_commands.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/accelerators/debug_commands.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/common/accelerators/exit_warning_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/accelerators/exit_warning_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/ime_control_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/ime_control_delegate.h View 1 chunk +0 lines, -40 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/global_shortcut_listener_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/accelerator_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_screenshot_grabber_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accelerator_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accelerator_utils_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
TBR as this is a straight move.
4 years, 5 months ago (2016-07-21 16:05:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166793005/20001
4 years, 5 months ago (2016-07-21 16:06:01 UTC) #5
James Cook
lgtm
4 years, 5 months ago (2016-07-21 16:14:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 16:56:33 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 16:57:52 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/de61f98917bb57f90490a730b23168b85722868d
Cr-Commit-Position: refs/heads/master@{#406877}

Powered by Google App Engine
This is Rietveld 408576698