Don't hide V8 symbols in debug builds

Don't hide V8 symbols in debug builds

That way, backtraces should work

BUG=
R=machenbach@chromium.org

Committed: https://crrev.com/0ae0fbce8be4e708b1842b19717a2bd2f43f8154
Cr-Commit-Position: refs/heads/master@{#37905}

[jochen (gone - plz use gerrit), 2016-07-20 11:39:34]

ptal

[jochen (gone - plz use gerrit), 2016-07-20 11:40:38]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 11:40:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-20 11:41:07]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-07-20 11:41:20]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 11:41:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-07-20 11:45:11]

lgtm

[jochen (gone - plz use gerrit), 2016-07-20 11:47:01]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-07-20 11:47:03]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-07-20 11:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-07-20 11:55:30]

https://codereview.chromium.org/2168593002/diff/60001/gni/v8.gni
File gni/v8.gni (right):

https://codereview.chromium.org/2168593002/diff/60001/gni/v8.gni#newcode38
gni/v8.gni:38: v8_enable_backtrace = is_debug && !v8_optimized_debug
Consider turning it on by default for all debug builds if the increase in binary
size is not too much.

[commit-bot: I haz the power, 2016-07-20 12:52:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-20 12:56:05]

Description was changed from

==========
Don't hide V8 symbols in debug builds

That way, backtraces should work

BUG=
R=machenbach@chromium.org
==========

to

==========
Don't hide V8 symbols in debug builds

That way, backtraces should work

BUG=
R=machenbach@chromium.org

Committed: https://crrev.com/0ae0fbce8be4e708b1842b19717a2bd2f43f8154
Cr-Commit-Position: refs/heads/master@{#37905}
==========

[commit-bot: I haz the power, 2016-07-20 12:56:06]

Patchset 4 (id:??) landed as
https://crrev.com/0ae0fbce8be4e708b1842b19717a2bd2f43f8154
Cr-Commit-Position: refs/heads/master@{#37905}

[Mark Mentovai, 2016-07-22 14:47:07]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-07-22 14:47:08]

This breaks debug non-component builds on Mac, which now fail the verify_order
step:

../../chrome/tools/build/mac/verify_order: unordered symbols in Chromium
Framework.framework/Chromium Framework:
__ZN2v88internal9Accessors12MakeAccessorEPNS0_7IsolateENS0_6HandleINS0_4NameEEEPFvNS_5LocalINS_4NameEEERKNS_20PropertyCallbackInfoINS_5ValueEEEEPFvS9_NS7_ISB_EERKNSA_IvEEENS0_18PropertyAttributesE
[…lots of other v8 symbols…]

This is the default build configuration for Chrome with no gn args set.

I also don’t see why this should be necessary. Symbol hiding should have no
impact on backtrace symbolization.

I think that this change should be reverted.

[Mark Mentovai, 2016-07-22 14:57:30]

(This rolled into Chrome at https://crrev.com/c7cba53d2f8c, but was probably
masked until https://crrev.com/d65ec5c9df40 landed, which explains why I’m only
seeing it this morning.)

[Mark Mentovai, 2016-07-22 15:06:33]

https://crbug.com/630629.

Revert CL: https://codereview.chromium.org/2170393003.