Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: gni/v8.gni

Issue 2168593002: Don't hide V8 symbols in debug builds (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("//build/config/v8_target_cpu.gni") 6 import("//build/config/v8_target_cpu.gni")
7 7
8 declare_args() { 8 declare_args() {
9 # Indicate if valgrind was fetched as a custom deps to make it available on 9 # Indicate if valgrind was fetched as a custom deps to make it available on
10 # swarming. 10 # swarming.
11 v8_has_valgrind = false 11 v8_has_valgrind = false
12 12
13 # Indicate if gcmole was fetched as a hook to make it available on swarming. 13 # Indicate if gcmole was fetched as a hook to make it available on swarming.
14 v8_gcmole = false 14 v8_gcmole = false
15 15
16 # Turns on compiler optimizations in V8 in Debug build. 16 # Turns on compiler optimizations in V8 in Debug build.
17 v8_optimized_debug = true 17 v8_optimized_debug = true
18 18
19 # Support for backtrace_symbols on linux.
20 v8_enable_backtrace = ""
21
19 # Enable the snapshot feature, for fast context creation. 22 # Enable the snapshot feature, for fast context creation.
20 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html 23 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html
21 v8_use_snapshot = true 24 v8_use_snapshot = true
22 25
23 # Use external files for startup data blobs: 26 # Use external files for startup data blobs:
24 # the JS builtins sources and the start snapshot. 27 # the JS builtins sources and the start snapshot.
25 v8_use_external_startup_data = "" 28 v8_use_external_startup_data = ""
26 } 29 }
27 30
28 if (v8_use_external_startup_data == "") { 31 if (v8_use_external_startup_data == "") {
29 # If not specified as a gn arg, use external startup data by default if 32 # If not specified as a gn arg, use external startup data by default if
30 # a snapshot is used and if we're not on ios. 33 # a snapshot is used and if we're not on ios.
31 v8_use_external_startup_data = v8_use_snapshot && !is_ios 34 v8_use_external_startup_data = v8_use_snapshot && !is_ios
32 } 35 }
33 36
37 if (v8_enable_backtrace == "") {
38 v8_enable_backtrace = is_debug && !v8_optimized_debug
Michael Achenbach 2016/07/20 11:55:30 Consider turning it on by default for all debug bu
39 }
40
34 ############################################################################### 41 ###############################################################################
35 # Templates 42 # Templates
36 # 43 #
37 44
38 # Points to // in v8 stand-alone or to //v8/ in chromium. We need absolute 45 # Points to // in v8 stand-alone or to //v8/ in chromium. We need absolute
39 # paths for all configs in templates as they are shared in different 46 # paths for all configs in templates as they are shared in different
40 # subdirectories. 47 # subdirectories.
41 v8_path_prefix = get_path_info("../", "abspath") 48 v8_path_prefix = get_path_info("../", "abspath")
42 49
43 # Common configs to remove or add in all v8 targets. 50 # Common configs to remove or add in all v8 targets.
(...skipping 12 matching lines...) Expand all
56 63
57 # TODO(crbug.com/621335) Rework this so that we don't have the confusion 64 # TODO(crbug.com/621335) Rework this so that we don't have the confusion
58 # between "optimize_speed" and "optimize_max". 65 # between "optimize_speed" and "optimize_max".
59 if (is_posix && !is_android && !is_nacl && !using_sanitizer) { 66 if (is_posix && !is_android && !is_nacl && !using_sanitizer) {
60 v8_add_configs += [ "//build/config/compiler:optimize_speed" ] 67 v8_add_configs += [ "//build/config/compiler:optimize_speed" ]
61 } else { 68 } else {
62 v8_add_configs += [ "//build/config/compiler:optimize_max" ] 69 v8_add_configs += [ "//build/config/compiler:optimize_max" ]
63 } 70 }
64 } 71 }
65 72
73 if (is_posix && v8_enable_backtrace) {
74 v8_remove_configs += [ "//build/config/gcc:symbol_visibility_hidden" ]
75 v8_add_configs += [ "//build/config/gcc:symbol_visibility_default" ]
76 }
77
66 # All templates should be kept in sync. 78 # All templates should be kept in sync.
67 template("v8_source_set") { 79 template("v8_source_set") {
68 source_set(target_name) { 80 source_set(target_name) {
69 forward_variables_from(invoker, "*", [ "configs" ]) 81 forward_variables_from(invoker, "*", [ "configs" ])
70 configs += invoker.configs 82 configs += invoker.configs
71 configs -= v8_remove_configs 83 configs -= v8_remove_configs
72 configs += v8_add_configs 84 configs += v8_add_configs
73 } 85 }
74 } 86 }
75 87
(...skipping 11 matching lines...) Expand all
87 } 99 }
88 100
89 template("v8_component") { 101 template("v8_component") {
90 component(target_name) { 102 component(target_name) {
91 forward_variables_from(invoker, "*", [ "configs" ]) 103 forward_variables_from(invoker, "*", [ "configs" ])
92 configs += invoker.configs 104 configs += invoker.configs
93 configs -= v8_remove_configs 105 configs -= v8_remove_configs
94 configs += v8_add_configs 106 configs += v8_add_configs
95 } 107 }
96 } 108 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698