Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2170393003: Revert "Don't hide V8 symbols in debug builds" (Closed)

Created:
4 years, 5 months ago by Mark Mentovai
Modified:
4 years, 5 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Don't hide V8 symbols in debug builds" This reverts commit 0ae0fbce8be4e708b1842b19717a2bd2f43f8154. BUG=chromium:630629 Closed in favor of https://codereview.chromium.org/2171373002.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M gni/v8.gni View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
4 years, 5 months ago (2016-07-22 15:05:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170393003/1
4 years, 5 months ago (2016-07-22 15:06:00 UTC) #2
Mark Mentovai
Description was changed from ========== Revert "Don't hide V8 symbols in debug builds" This reverts ...
4 years, 5 months ago (2016-07-22 15:25:10 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-22 15:26:31 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-22 15:26:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-22 15:26:40 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-22 15:26:41 UTC) #7
Mark Mentovai
Description was changed from ========== Revert "Don't hide V8 symbols in debug builds" This reverts ...
4 years, 5 months ago (2016-07-22 15:31:48 UTC) #8
Mark Mentovai
4 years, 5 months ago (2016-07-22 15:31:59 UTC) #9
Message was sent while issue was closed. 
Description was changed from

==========
Revert "Don't hide V8 symbols in debug builds"

This reverts commit 0ae0fbce8be4e708b1842b19717a2bd2f43f8154.

BUG=chromium:630629

Closed in favor of https://codereview.chromium.org/2171373002
==========

to

==========
Revert "Don't hide V8 symbols in debug builds"

This reverts commit 0ae0fbce8be4e708b1842b19717a2bd2f43f8154.

BUG=chromium:630629

Closed in favor of https://codereview.chromium.org/2171373002.
==========

Powered by Google App Engine
This is Rietveld 408576698