Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2168513004: [DO NOT COMMIT] ServiceWorker: First touch of mojo (Closed)

Created:
4 years, 5 months ago by shimazu
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, yzshen+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, jsbell+serviceworker_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, haraken, michaeln, serviceworker-reviews, falken, Aaron Boodman, kinuko+serviceworker, horo+watch_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT COMMIT] ServiceWorker: First touch of mojo BUG=629701

Patch Set 1 #

Patch Set 2 : Handle dispose() in ServiceWorkerGlobalScopeClient on a right thread #

Patch Set 3 : Adding fetchevent #

Patch Set 4 : Implementing FetchEvent #

Patch Set 5 : Use StructTraits #

Patch Set 6 : Add DidHandleSimpleEvent to ServiceWorkerGlobaScopeHost with trying EnumTraits #

Patch Set 7 : Add files #

Patch Set 8 : Remove an unnecessary file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+799 lines, -36 lines) Patch
M content/browser/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 2 3 4 5 5 chunks +91 lines, -0 lines 0 comments Download
A content/browser/service_worker/service_worker_global_scope_host_impl.h View 1 2 3 4 5 1 chunk +47 lines, -0 lines 0 comments Download
A content/browser/service_worker/service_worker_global_scope_host_impl.cc View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 2 3 4 5 6 chunks +40 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 3 4 5 5 chunks +22 lines, -7 lines 0 comments Download
A content/common/service_worker/service_worker_event_status.typemap View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
A content/common/service_worker/service_worker_event_status_struct_traits.h View 1 2 3 4 5 6 1 chunk +42 lines, -0 lines 0 comments Download
A content/common/service_worker/service_worker_event_status_struct_traits.cc View 1 2 3 4 5 6 1 chunk +38 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/background_sync/background_sync_client_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 2 3 4 5 5 chunks +11 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 3 4 5 5 chunks +16 lines, -12 lines 0 comments Download
A + content/typemaps.gni View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 2 3 4 5 4 chunks +27 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 2 3 4 5 4 chunks +105 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/WebServiceWorkerStructTraits.cpp View 1 2 3 4 5 6 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/service_worker_types.typemap View 1 2 3 4 5 6 1 chunk +36 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink_typemaps.gni View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerEventResult.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerStructTraits.h View 1 2 3 4 5 6 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/serviceworker/service_worker_event_status.typemap View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/serviceworker/service_worker_global_scope.mojom View 1 2 3 4 5 1 chunk +151 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 2 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2190853003 Patch 1

Messages

Total messages: 1 (1 generated)
shimazu
4 years ago (2016-12-22 03:13:36 UTC) #1 
Description was changed from

==========
[DO NOT COMMIT] ServiceWorker: First touch of mojo

BUG=629701
==========

to

==========
[DO NOT COMMIT] ServiceWorker: First touch of mojo

BUG=629701
==========

Powered by Google App Engine
This is Rietveld 408576698