Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2190853003: ServiceWorker: Unregister SW after finishing activation.html (Closed)

Created:
4 years, 4 months ago by shimazu
Modified:
4 years, 4 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Unregister SW after finishing activation.html Calling registration.unregister instead of returning registration.unregister BUG=632256 TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Release http/tests/serviceworker/activation.html Committed: https://crrev.com/88da30c52b97f4aefe60c35f37bc1a62c9ab7d30 Cr-Commit-Position: refs/heads/master@{#408573}

Patch Set 1 #

Messages

Total messages: 14 (8 generated)
shimazu (google)
ptal
4 years, 4 months ago (2016-07-28 08:45:35 UTC) #2
shimazu
4 years, 4 months ago (2016-07-28 08:47:01 UTC) #4
nhiroki
LGTM, thank you!
4 years, 4 months ago (2016-07-29 02:28:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190853003/1
4 years, 4 months ago (2016-07-29 04:11:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 04:15:17 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 04:16:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88da30c52b97f4aefe60c35f37bc1a62c9ab7d30
Cr-Commit-Position: refs/heads/master@{#408573}

Powered by Google App Engine
This is Rietveld 408576698