third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 2168513004: [DO NOT COMMIT] ServiceWorker: First touch of mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 2168513004: [DO NOT COMMIT] ServiceWorker: First touch of mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove an unnecessary file Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/chromium_bindings_configuration.gni ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

index 6faa08e31304b61f046b2286e020d3f1f6afb9cc..880cea0ba6c5bebe5e93beb6bc7fc0ee7578201d 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -258,6 +258,7 @@ void RespondWithObserver::responseWasFulfilled(const ScriptValue& value)

response->populateWebServiceWorkerResponse(webResponse);

BodyStreamBuffer* buffer = response->internalBodyBuffer();

if (buffer) {

+ LOG(ERROR) << "create buffer";

RefPtr<BlobDataHandle> blobDataHandle = buffer->drainAsBlobDataHandle(FetchDataConsumerHandle::Reader::AllowBlobWithInvalidSize);

if (blobDataHandle) {

webResponse.setBlobDataHandle(blobDataHandle);